[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 23/36] arm64,smp: Remove trace_.*_rcuidle() usage
 
- To: Mark Rutland <mark.rutland@xxxxxxx>
 
- From: Marc Zyngier <maz@xxxxxxxxxx>
 
- Date: Wed, 15 Jun 2022 07:05:11 +0100
 
- Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>,	rth@xxxxxxxxxxx,	ink@xxxxxxxxxxxxxxxxxxxx,	mattst88@xxxxxxxxx,	vgupta@xxxxxxxxxx,	linux@xxxxxxxxxxxxxxx,	ulli.kroll@xxxxxxxxxxxxxx,	linus.walleij@xxxxxxxxxx,	shawnguo@xxxxxxxxxx,	Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>,	kernel@xxxxxxxxxxxxxx,	festevam@xxxxxxxxx,	linux-imx@xxxxxxx,	tony@xxxxxxxxxxx,	khilman@xxxxxxxxxx,	catalin.marinas@xxxxxxx,	will@xxxxxxxxxx,	guoren@xxxxxxxxxx,	bcain@xxxxxxxxxxx,	chenhuacai@xxxxxxxxxx,	kernel@xxxxxxxxxx,	geert@xxxxxxxxxxxxxx,	sammy@xxxxxxxxx,	monstr@xxxxxxxxx,	tsbogend@xxxxxxxxxxxxxxxx,	dinguyen@xxxxxxxxxx,	jonas@xxxxxxxxxxxx,	stefan.kristiansson@xxxxxxxxxxxxx,	shorne@xxxxxxxxx,	James.Bottomley@xxxxxxxxxxxxxxxxxxxxx,	deller@xxxxxx,	mpe@xxxxxxxxxxxxxx,	benh@xxxxxxxxxxxxxxxxxxx,	paulus@xxxxxxxxx,	paul.walmsley@xxxxxxxxxx,	palmer@xxxxxxxxxxx,	aou@xxxxxxxxxxxxxxxxx,	hca@xxxxxxxxxxxxx,	gor@xxxxxxxxxxxxx,	agordeev@xxxxxxxxxxxxx,	borntraeger@xxxxxxxxxxxxx,	svens@xxxxxxxxxxxxx,	ysato@xxxxxxxxxxxxxxxxxxxx,	dalias@xxxxxxxx,	davem@xxxxxxxxxxxxx,	richard@xxxxxx,	anton.ivanov@xxxxxxxxxxxxxxxxxx,	johannes@xxxxxxxxxxxxxxxx,	tglx@xxxxxxxxxxxxx,	mingo@xxxxxxxxxx,	bp@xxxxxxxxx,	dave.hansen@xxxxxxxxxxxxxxx,	x86@xxxxxxxxxx,	hpa@xxxxxxxxx,	acme@xxxxxxxxxx,	alexander.shishkin@xxxxxxxxxxxxxxx,	jolsa@xxxxxxxxxx,	namhyung@xxxxxxxxxx,	jgross@xxxxxxxx,	srivatsa@xxxxxxxxxxxxx,	amakhalov@xxxxxxxxxx,	pv-drivers@xxxxxxxxxx,	boris.ostrovsky@xxxxxxxxxx,	chris@xxxxxxxxxx,	jcmvbkbc@xxxxxxxxx,	rafael@xxxxxxxxxx,	lenb@xxxxxxxxxx,	pavel@xxxxxx,	gregkh@xxxxxxxxxxxxxxxxxxx,	mturquette@xxxxxxxxxxxx,	sboyd@xxxxxxxxxx,	daniel.lezcano@xxxxxxxxxx,	lpieralisi@xxxxxxxxxx,	sudeep.holla@xxxxxxx,	agross@xxxxxxxxxx,	bjorn.andersson@xxxxxxxxxx,	anup@xxxxxxxxxxxxxx,	thierry.reding@xxxxxxxxx,	jonathanh@xxxxxxxxxx,	jacob.jun.pan@xxxxxxxxxxxxxxx,	Arnd Bergmann <arnd@xxxxxxxx>,	yury.norov@xxxxxxxxx,	andriy.shevchenko@xxxxxxxxxxxxxxx,	linux@xxxxxxxxxxxxxxxxxx,	rostedt@xxxxxxxxxxx,	pmladek@xxxxxxxx,	senozhatsky@xxxxxxxxxxxx,	john.ogness@xxxxxxxxxxxxx,	paulmck@xxxxxxxxxx,	frederic@xxxxxxxxxx,	quic_neeraju@xxxxxxxxxxx,	josh@xxxxxxxxxxxxxxxx,	mathieu.desnoyers@xxxxxxxxxxxx,	jiangshanlai@xxxxxxxxx,	joel@xxxxxxxxxxxxxxxxx,	juri.lelli@xxxxxxxxxx,	vincent.guittot@xxxxxxxxxx,	dietmar.eggemann@xxxxxxx,	bsegall@xxxxxxxxxx,	mgorman@xxxxxxx,	bristot@xxxxxxxxxx,	vschneid@xxxxxxxxxx,	jpoimboe@xxxxxxxxxx,	linux-alpha@xxxxxxxxxxxxxxx,	linux-kernel@xxxxxxxxxxxxxxx,	linux-snps-arc@xxxxxxxxxxxxxxxxxxx,	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,	linux-omap@xxxxxxxxxxxxxxx,	linux-csky@xxxxxxxxxxxxxxx,	linux-hexagon@xxxxxxxxxxxxxxx,	linux-ia64@xxxxxxxxxxxxxxx,	linux-m68k@xxxxxxxxxxxxxxxxxxxx,	linux-mips@xxxxxxxxxxxxxxx,	openrisc@xxxxxxxxxxxxxxxxxxxx,	linux-parisc@xxxxxxxxxxxxxxx,	linuxppc-dev@xxxxxxxxxxxxxxxx,	linux-riscv@xxxxxxxxxxxxxxxxxxx,	linux-s390@xxxxxxxxxxxxxxx,	linux-sh@xxxxxxxxxxxxxxx,	sparclinux@xxxxxxxxxxxxxxx,	linux-um@xxxxxxxxxxxxxxxxxxx,	linux-perf-users@xxxxxxxxxxxxxxx,	virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx,	linux-xtensa@xxxxxxxxxxxxxxxx,	linux-acpi@xxxxxxxxxxxxxxx,	linux-pm@xxxxxxxxxxxxxxx,	linux-clk@xxxxxxxxxxxxxxx,	linux-arm-msm@xxxxxxxxxxxxxxx,	linux-tegra@xxxxxxxxxxxxxxx,	linux-arch@xxxxxxxxxxxxxxx,	rcu@xxxxxxxxxxxxxxx
 
- Delivery-date: Wed, 15 Jun 2022 06:07:28 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On Tue, 14 Jun 2022 17:24:48 +0100,
Mark Rutland <mark.rutland@xxxxxxx> wrote:
> 
> On Wed, Jun 08, 2022 at 04:27:46PM +0200, Peter Zijlstra wrote:
> > Ever since commit d3afc7f12987 ("arm64: Allow IPIs to be handled as
> > normal interrupts") this function is called in regular IRQ context.
> > 
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> 
> [adding Marc since he authored that commit]
> 
> Makes sense to me:
> 
>   Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
> 
> Mark.
> 
> > ---
> >  arch/arm64/kernel/smp.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- a/arch/arm64/kernel/smp.c
> > +++ b/arch/arm64/kernel/smp.c
> > @@ -865,7 +865,7 @@ static void do_handle_IPI(int ipinr)
> >     unsigned int cpu = smp_processor_id();
> >  
> >     if ((unsigned)ipinr < NR_IPI)
> > -           trace_ipi_entry_rcuidle(ipi_types[ipinr]);
> > +           trace_ipi_entry(ipi_types[ipinr]);
> >  
> >     switch (ipinr) {
> >     case IPI_RESCHEDULE:
> > @@ -914,7 +914,7 @@ static void do_handle_IPI(int ipinr)
> >     }
> >  
> >     if ((unsigned)ipinr < NR_IPI)
> > -           trace_ipi_exit_rcuidle(ipi_types[ipinr]);
> > +           trace_ipi_exit(ipi_types[ipinr]);
> >  }
> >  
> >  static irqreturn_t ipi_handler(int irq, void *data)
Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
        M.
-- 
Without deviation from the norm, progress is not possible.
 
    
     |