Re: [PATCH v2 2/2] xen/arm: add FF-A mediator

[Julien Grall <julien@xxxxxxx>]

Hi,

On 11/06/2022 02:23, Stefano Stabellini wrote:
> > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr,
> > +                             uint32_t page_count)
> > +{
> > +    const struct arm_smccc_1_2_regs arg = {
> > +#ifdef CONFIG_ARM_64
> > +        .a0 = FFA_RXTX_MAP_64,
> > +#endif
> This ifdef is unnecessary given that FFA depends on ARM64 and SMCCCv1.2
> is only implemented on ARM64. It also applies to all the other ifdefs in
> this file. You can remove the code under #ifdef CONFIG_ARM_32.
To me the #ifdef indicates that it would be possible to use FFA on 
arm32. So I think it is better to keep them rather than having to 
retrofitting them in the future.
Cheers,

--
Julien Grall