[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID


  • To: Jane Malalane <jane.malalane@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 10 Jun 2022 17:49:18 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WK/EBB/WkeUGGPPya+wMX8gD82aPsuxbyLsNpof2Mds=; b=BX0Tl5RMo9zY2bFpkUHKRSt3zPLHomYaDxrq6XyomcwK7BIVRBvVf2hA6H4EhjPSBx14dR2Qxg3QiLxjY8C67ivGfHmas1lYLf2PZV2nxNqjUYRQyJ/H/Ls0RlmoNoT9jWB6InD1d6g5UlnHP6SlRvzEVLKOYR68wj9n/NeJggW+AZ1LNV89DSxzJNhc7zueO3x33+PcEZiZ4sGcbyaE8jgHOYtqjg9Kx/dr5wI4VOviCvww6agmoHPrr5OJi82DNlEBhfbxtLF9qUx2OIuEzZM2hBOG91CSs67DZfJGW0v3/6fdg5hhi5REUYaFY1EVgXt4EFWPyF5spjsE+5Pkkg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fvBlsBIp7ZiDYmA1wlZ1Im0Tok3kFfGa2zcvZiwQgXY9ierNvFhodcx462uTyY9UuWxOJGtWgOOcTiYQrm8gS1agy4M+5n9ZW+nPq5TSItikjtVR3Xgr6V3KWguolSParOWhJca7lEJxDPEecdmywN1h9ghsQqfWZm5SO09ObEiGOfTdo0LqjBzdh1p2i3s+qqxdHIZraGjsZXwVA2OMXmFUK+D/9eRt12NUkvc5YszPi6vWIbmnFfx9dVq1Y7pDBLNkHbLKsbkkkYLHCaRa9iHXWue4c00ayfsbQGRf6n5hEaE4cCBLe/Lns5/GyPbN9bEl1eOSdGU0GGEs7nqitA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 10 Jun 2022 15:49:37 +0000
  • Ironport-data: A9a23:g+TicqvLuAkQrU0Thu+6Yc61U+fnVCNfMUV32f8akzHdYApBsoF/q tZmKWGBP/vfY2f0Ktp1aYy+8EsHucTTn4dqSQBlqik8Ey8W+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW13U4 YuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8oGYjwqfUjVyVAHnxuN592x7/KAFqw5Jn7I03uKxMAwt1IJWRuYcg037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4ADmmth7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9wnO+fJusjW7IApZ4uLBK/TLRPm2T8RWlxeHl D/K3V3YK0RPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BVJ lEQ+yEuhbMv70HtRd74NzWnpFaUsxhaXMBfe9DW8ymIw6vQpgqcWG4NS2YdbMR87JNnAzs3y lWOgtXlQyR1t6GYQm6c8bHSqi6uPS8SLikJYipsoRY53uQPabob1nrnJuuP2obs5jEpMVkcG wy3kRU=
  • Ironport-hdrordr: A9a23:DOsZvaBVqPix1PjlHeg+sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl4N6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1wjegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvW/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kdb11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtVqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW7HAbgcYa hT5fznlbZrmQvwVQGbgoAv+q3gYp0LJGbJfqBY0fblkQS/nxhCvj4lLYIk7zI9HakGOuh5Dt T/Q9pVfY51P78rhIJGdZA8qJiMexrwqSylChPgHX3XUIc6Blnql7nbpJ0I2cDCQu178HJ1ou WKbG9l
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Jun 10, 2022 at 12:07:04PM +0100, Jane Malalane wrote:
> Have is_hvm_pv_evtchn_domain() return true for vector callbacks for
> evtchn delivery set up on a per-vCPU basis via
> HVMOP_set_evtchn_upcall_vector.
> 
> Assume that if vCPU0 uses HVMOP_set_evtchn_upcall_vector, all
> remaining vCPUs will too and thus remove is_hvm_pv_evtchn_vcpu() and
> replace sole caller with is_hvm_pv_evtchn_domain().
> 
> is_hvm_pv_evtchn_domain() returning true is a condition for setting up
> physical IRQ to event channel mappings. Therefore, also add a CPUID
> bit so that guests know whether the check in is_hvm_pv_evtchn_domain()
> will fail when using HVMOP_set_evtchn_upcall_vector. This matters for
> guests that route PIRQs over event channels since
> is_hvm_pv_evtchn_domain() is a condition in physdev_map_pirq().
> 
> The naming of the CPUID bit is quite generic about upcall support
> being available. That's done so that the define name doesn't become
> overly long.
> 
> A guest that doesn't care about physical interrupts routed over event
> channels can just test for the availability of the hypercall directly
> (HVMOP_set_evtchn_upcall_vector) without checking the CPUID bit.
> 
> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.