[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Fri, 10 Jun 2022 11:01:29 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0PpqRd62Ww4ABzLBXizCPsL0GJo+mfrFrxck1m5u3Ew=; b=Ry+DhEFypzGw/UWCKq2rx5nKjtMYdsOCURPhOI6qvPs6HvDOT3zY3usXGeuSHQRXAHBmDav0O2taUG2sXKgKVyPNnBePgQ3VXprvd7JcaP8qXGbXVcMiAeHwOMyYYsRwykEZbeT6L+Vc7Hul/vYVK1aaCXacPO5F1dDRv2ACLbArSVEIuCT+uMVx0l5BJib0fadbdcC4qQthGV095STlPfUw39U9dOakQKAI30SL6qnA/4C/Agn5rgB0Vra0hN6mJCr+sagS3KB1HpWxBVa0tXnTkWUBok+dxCOtLgw9BT0dfr/kQGf/IS1dbQO0M4VcXxsHXs1JJbyN/EP+s1sZ7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mnJWOGppM/8HnHM2TIz0IVluyRafwnjXKSw0pE480zomsqcA8X+j6KseuLyf/U3xwBDFGZYUL0PEJ160bCVJQTmOlj5F8xiSCmqaauGCUPlQkmxeSB7/TpsXcWp9tu/BlINsokBFrh+2fDY0uOz78zwCFeQNhO2eva4I6ovTfPkaZQTs5r5xbAheVrBgjrktEvfiz5ipACJToJ48fcu3xJQ1eB7PPhRu4HBKL28KX4zeXFvajMpNcG4pB0ukxbEvrAVYX32HZiWleYclrvczbFKvuv/obICUtRyTt8IuYyC8mF5cpoQfUFW7eU2nZR2qxsft5Qwuy4WnXtMVVSvAKg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 10 Jun 2022 11:01:48 +0000
- Ironport-data: A9a23:NLzRya8/En4aIjfmoLMeDrUD8H+TJUtcMsCJ2f8bNWPcYEJGY0x3y GpKCz+EPf3bYGT2ftkgaIrj/B9QuZ7dmtVrSwZoq3s8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ44f5fs7Rh2NQw34HhW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnazseB94D5Hho+kmeSJHE39OD/VD5oaSdBBTseTLp6HHW13F5qw2SW0TY8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHvWMvIcBtNszrpkm8fL2R cMfZHxKZRDJZxRJN38cCY4knffujX76G9FdgA3P+/dqszaIpOB3+OCwLsvbIO7JecJ6sHuan EnbwWrTJjhPYbRzzhLAqBpAnNTnnyn2RYYTH72Q7eNxjRuYwWl7IAISfUu2p7++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUHBBqlz6PV50OVAzYCRzsYMNg+7pZuHHoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd17UZxRmYL +i2kRUD
- Ironport-hdrordr: A9a23:87qk362ONiBdq/iYZfRVhwqjBRByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplHYIrZVy1r lG0HmesIcSBRTcnD7l79yNTB1ykFGoyEBS2NL7okYvJrf2UoUh27D3PXklY6soDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRSAtG7Wu79jDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYarsTV0eGhfiv2kicWrZcofLe1a0uLGIAgBpxAoA=
- Thread-topic: [PATCH v3] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID
On 24/05/2022 16:14, Jan Beulich wrote:
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> On 18.05.2022 15:27, Jane Malalane wrote:
>> --- a/xen/arch/x86/include/asm/domain.h
>> +++ b/xen/arch/x86/include/asm/domain.h
>> @@ -14,8 +14,14 @@
>>
>> #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo)
>>
>> +/*
>> + * Set to true if either the global vector-type callback or per-vCPU
>> + * LAPIC vectors are used. Assume all vCPUs will use
>> + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does.
>> + */
>> #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \
>> - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector)
>> + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \
>> + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector))
>> #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain))
>
> I continue to think that with the vCPU0 dependency added to
> is_hvm_pv_evtchn_domain(), is_hvm_pv_evtchn_vcpu() should either
> be adjusted as well (to check the correct vCPU's field) or be
> deleted (and the sole caller be replaced).
>
> Jan
I will replace it in a newer version of the patch.
Thank you.
Jane.
|
