Re: [PATCH 3/3] xen/console: Fix incorrect format tags for struct tm members

[Juergen Gross <jgross@xxxxxxxx>]

On 10.06.22 11:44, Jan Beulich wrote:
> On 10.06.2022 10:33, Michal Orzel wrote:
> > All the members of struct tm are defined as integers but the format tags
> > used in console driver for snprintf wrongly expect unsigned values. Fix
> > the tags to expect integers.
> Perhaps do things the other way around - convert field types to unsigned
> unless negative values can be stored there? This would match our general
> aim of using unsigned types when only non-negative values can be held in
> variables / parameters / fields.
Don't you think keeping struct tm in sync with the Posix definition should
be preferred here?


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature