[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 1/4] build: xen/include: use if_changed


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Thu, 9 Jun 2022 14:26:47 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXQt8AAD0BbyAzVfLu9P2t3Skg4ZAY9an+vYNmZO0fk=; b=CwsC5zey0zUm4/N7fyALZrr9Hutv8+7OreDBbmKshrMQLpSpAQavk1QVs280fFAtMyCSfjA6vOgXOFV4fki06Fp5hIFM+44LL7Nv9xBiqdg7o37mbAYhvHJTtFyI9Nv5px38FQlRou4C8qidhVjo2sgxuiq6Df8O9XDiO8EpY3gqA5lOkmzwMB1k5oZ8PvmZu03OI867D6s3zFcdmNX5vXFUA1qi+9vp8rCAyMeP4mxJLA23te3yZC9YhxQeTipJDYCjmpyb/nbNznjtjDDg3KWaSWBOCQbBlQLVlqeee8E1nwVUvLj9hr3uCV8Y35Z73cmNOPcjindUiUscB00IYg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXQt8AAD0BbyAzVfLu9P2t3Skg4ZAY9an+vYNmZO0fk=; b=A8wDWEb2HmEOViAq68eRfz/CMdmB0KSniwPE9+nIojKrKJYEzYPc9+X859/Puf2dtFnZRkpfnOCuFmR5646VQcR4M5vHkegZ3nNlGsTHMfjoJ4qRSXM+FBuUUFyWqkzQeYhYAo27P1R6fyqKOLhVP97mVH1ODNUzc4FCcgKzxxwJ1GBwxljQR71eHdcRVSwc8hfp9tF4PixE6D3tYXGl/J1zSFa09S6KutiCHUyyR2zLPAcXt3PrUrkm1n+f54prNiK/MUPHTZyLLDEK704RI6FK017ZDXzKv/uvyWQOmeexnLie2WkBuYK0BinuGuF+EwovH5k5uVjJ8r4qSLNKPA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mOwsHeif3aKvUaDwji3/QC6pDlancOfMUAHwggmM0oqW8WOE5uZnNacynr47WPA/fdvz0UWXNxYSlYzjWV+2iYabIal53lOUvpPJC0Mz6QTXTDIPy8XTPkV80kqVYv3Zvr6JfBleWsgvXDT4gaM/Gq6nHDNlX61XNFf/LZ5fmmXYM4Jl6cspw7WlmdV1pqXwARFAY/KF9IQInIE7oJ2XIqjgjLyv3/E73BuLdYJQhL4pCdn0cjthG0PsevoebTRwHVZehYQwCg/+e/TMnb/BqU26U1KR0x0wkuWb/vjXnLOby17oL8XxbXEsMtZ1lliTkhBbc9zWA4tbZeBWxiA9Fg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kfEfhstPjtJgFhUKCVhyWFm6rCg6FGoCSuOIfEbjxUHt7mF7pyS56toIKQ1wNr/rLy1qdQOo6qkxZz7ZL/EFBwAU1CNBDKJ/djiI0mA2vUnlHYrBtBVchWdks2PZC4PnIvOgoSCUfoGLYf6lFR//Zkn1pBnCd72DmbvSmGdNs6OE9kj1Q35cBERbUP2hoQxa5xEQq5SbOQg5g23H9nrbsz8YFUSfvEguf5fsPSpQ7ZEhBxW1tfMur0b11PHNQdXjA/AjhMksJnlpafsJE/UftBPEs0y/sxNEQ09WLawZn/l7GWZPlSIaTvrXSoCOqmli/sC6D4RYfwrm0oWMXTGsdQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 09 Jun 2022 14:27:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYddkD4JsESJA0gkGnWWwykzQjSK1G6E+AgAAC3wCAABeVAIAAEeqAgAAZh4A=
  • Thread-topic: [XEN PATCH 1/4] build: xen/include: use if_changed

Hi Antony,

> On 9 Jun 2022, at 13:55, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
> 
> On Thu, Jun 09, 2022 at 11:51:20AM +0000, Bertrand Marquis wrote:
>> Hi,
>> 
>>> On 9 Jun 2022, at 11:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> 
>>> On 09.06.2022 12:16, Bertrand Marquis wrote:
>>>> With this change, compiling for x86 is now ending up in:
>>>> CHK     include/headers99.chk
>>>> make[9]: execvp: /bin/sh: Argument list too long
>>>> make[9]: *** [include/Makefile:181: include/headers++.chk] Error 127
>>>> 
>>>> Not quite sure yet why but I wanted to signal it early as other might be 
>>>> impacted.
>>>> 
>>>> Arm and arm64 builds are not impacted.
>>> 
>>> Hmm, that patch has passed the smoke push gate already, so there likely is
>>> more to it than there being an unconditional issue. I did build-test this
>>> before pushing, and I've just re-tested on a 2nd system without seeing an
>>> issue.
>> 
>> I have the problem only when building using Yocto, I did a normal build and 
>> the
>> issue is not coming.
>> 
> 
> Will the following patch help?

Yes it does, thanks a lot.

You can add my:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> 
> 
> From 0f32f749304b233c0d5574dc6b14f66e8709feba Mon Sep 17 00:00:00 2001
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Date: Thu, 9 Jun 2022 13:42:52 +0100
> Subject: [XEN PATCH] build,include: rework shell script for headers++.chk
> 
> The command line generated for headers++.chk by make is quite long,
> and in some environment it is too long. This issue have been seen in
> Yocto build environment.
> 
> Error messages:
>    make[9]: execvp: /bin/sh: Argument list too long
>    make[9]: *** [include/Makefile:181: include/headers++.chk] Error 127
> 
> Rework to that we do the foreach loop in shell rather that make to
> reduce the command line size by a lot. We also need a way to get
> headers prerequisite for some public headers so we use a switch "case"
> in shell to be able to do some simple pattern matching. Variables
> alone in POSIX shell don't allow to work with associative array or
> variables with "/".
> 
> Reported-by: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Fixes: 28e13c7f43 ("build: xen/include: use if_changed")
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> xen/include/Makefile | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/include/Makefile b/xen/include/Makefile
> index 6d9bcc19b0..ca5e868f38 100644
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -158,13 +158,22 @@ define cmd_headerscxx_chk
>           touch $@.new;                                                     \
>           exit 0;                                                           \
>       fi;                                                                   \
> -     $(foreach i, $(filter %.h,$^),                                        \
> -         echo "#include "\"$(i)\"                                          \
> +     get_prereq() {                                                        \
> +         case $$1 in                                                       \
> +         $(foreach i, $(filter %.h,$^),                                    \
> +         $(if $($(patsubst $(srctree)/%,%,$i)-prereq),                     \
> +             $(patsubst $(srctree)/%,%,$i)$(close)                         \
> +             echo "$(foreach j, $($(patsubst $(srctree)/%,%,$i)-prereq),   \
> +                     -include c$(j))";;))                                  \
> +         esac;                                                             \
> +     };                                                                    \
> +     for i in $(filter %.h,$^); do                                         \
> +         echo "#include "\"$$i\"                                           \
>           | $(CXX) -x c++ -std=gnu++98 -Wall -Werror -D__XEN_TOOLS__        \
>             -include stdint.h -include $(srcdir)/public/xen.h               \
> -           $(foreach j, $($(patsubst $(srctree)/%,%,$i)-prereq), -include 
> c$(j)) \
> +           `get_prereq $$i`                                                \
>             -S -o /dev/null -                                               \
> -         || exit $$?; echo $(i) >> $@.new;) \
> +         || exit $$?; echo $$i >> $@.new; done;                            \
>       mv $@.new $@
> endef
> 
> 
> 
> 
> -- 
> Anthony PERARD




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.