[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 1/4] kconfig: allow configuration of maximum modules



On 01/06/2022 10:06, Roger Pau Monné wrote:
On Wed, Jun 01, 2022 at 07:40:12AM +0000, George Dunlap wrote:
The down side of this is that you can’t use “automatically remove trailing whitespace 
on save” features of some editors.

Without such automation, I introduce loads of trailing whitespace.  With such automation, I end up removing 
random trailing whitespace as I happen to touch files.  I’ve always done this by just adding 
“While here, remove some trailing whitespace” to the commit message, and there haven’t 
been any complaints.

FWIW, I have an editor feature that highlights trailing whitespace,
but doesn't remove it.

As said, I find it cumbersome to have to go through more jumps while
using `git blame` or similar, just because of unrelated cleanups.

IMO I don't think it's good practice to wholesale replace all trailing
whitespace from a file as part of an unrelated change.

+1

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.