[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] x86/vmx: implement Bus Lock detection


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 7 Jun 2022 08:54:15 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SC+WSNVhO9GML4oFShhKwiJYTk/8SC67TBz8JVyBbsg=; b=HOm8p3Zs/BPodXanjP3AWoLoRAfw+SQlA9nqy5UA2KzS0PvNFf8yfXYBjr4mrIIJ9Jefiaj9sRCiHjmMA3JK+aUyRv/uXL2qgQGOPibTs9So56YGKO3v6Wu9zCXIX0lUlSRouTcFt4BB8cVzyhC3kJxggQZtpun10DfA3Md1YSBwhkuqBNxwcqZ0VOUre1rAdGS+1J7badKorJTIDV7g2GCAzLs20iceBMOgsLJiX4/yB559Ns5nDYdZ0yFZyeD1XUWh85Z/yipmAbP88PrQwn2QSq3hkEGzCpNjBwftUbmoESS8KmuaavjdQEnX7C4Iw6kqoJxeVKcfIMxfShF+PA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fvseONVHoJKEuqnpiD0xNWqSULxAEd65vM6lSZXr0WAqRWoNdD0b07PBttztLvZQy4bb4/hp3ZqXqY/2em3ql7HyB6WH18GhnaP3Os1cjmomUCKkIoW5kmncqrNJ98NYdd+8D6gVnLqyCk5Lj1mlU1paIJGIeV8Da1qj+Os0mdxLqRuB9iOTgun0WdJ2G/7eTlkNCC1DwgpPToCpYRwdbIWdmd9d1kbj+AuVBX9jUcwF9ygupCBaKwld0suA5sHLl/dWMfRkPth8A2l3THtwtLW/l59GidXmDiaN+8IlSISUkCS/Y5gImghCPKChsbgv91d9XjfZoO81VUHE8/HP5A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 07 Jun 2022 06:54:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.06.2022 15:27, Andrew Cooper wrote:
> On 26/05/2022 12:11, Roger Pau Monne wrote:
>> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
>> index f08a00dcbb..476ab72463 100644
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -4065,6 +4065,16 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>>  
>>      if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) )
>>          return vmx_failed_vmentry(exit_reason, regs);
>> +    if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) )
>> +    {
>> +        /*
>> +         * Delivery of Bus Lock VM exit was pre-empted by a higher priority 
>> VM
>> +         * exit.
>> +         */
>> +        exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK;
>> +        if ( exit_reason != EXIT_REASON_BUS_LOCK )
>> +            perfc_incr(buslock);
>> +    }
> 
> I know this post-dates you posting v2, but given the latest update from
> Intel, VMX_EXIT_REASONS_BUS_LOCK will be set on all exits.

Mind me asking what "latest update" you're referring to? Neither SDM nor
ISE have seen a recent update, afaict.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.