[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v5 8/8] xen/x86: use INFO level for node's without memory log message


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Wei Chen <wei.chen@xxxxxxx>
  • Date: Mon, 6 Jun 2022 12:09:16 +0800
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lmHKEnpMdOqTyUo5+1ssJ2WrW3qZKZlnI4Gu4KfwTE=; b=ZWFcK8So5MvYvkYjwAe8qnQFQPugyvUF8l5HXRerJoOVQgDcva4pSpVJlLEO2VJDy0Egf/sF3y+bY9jOXrm3JScE0jBF1cLeGG2ku+pTKJpwH6w/WDKcnCLyQE7NOLe3mSbXy0TU8iKNwJobSccnFzKA4DMXxeVZ19kxA3gRXDYQpWranuONJjKT4V36O4dvp8kN3YKpIolbwfpEd25wv1l5GYc24EXHiuq7tTgBG3pcO0yqnCSyJviJxG1oNHwXPS1Mf7cmgLSJzpmAUfRKo99iywn1Jr+PB+X7xvNnWVg6KL3izJ8Vmui70pJLYhoRc4wYi4nXJ3A+MBACL7/4/g==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7lmHKEnpMdOqTyUo5+1ssJ2WrW3qZKZlnI4Gu4KfwTE=; b=FE+qQz27ToaiHkJAj2DjUR7+cw5lBj9aJ7Vi/10hgpm+XSZ9MXHIEMP3dM+zFe/HTp+rAcDBTKwnwINgPOEefzvcGuJNe6d0d8j9KCxRcMG9epvYR2X9XJhhd8LgWsYZl3Munxd7yznw8VDYsFJYxQZz08gq+aYX1zpAMEDTNC7rjNz16elr+T1RZvO1aHxTOpZW6Kf7ahjyMkmpzJxYrGj2wilnghRrVddYv4o/Ubr1K9i5fHa9eSpnt+y/BFgS1UVAlDtva49lZYo7vOelwQKbdh4ZaXBw/4Nx4KhxeXV/s/CDW9xHXyaFTYoUQkOl3rgHiMY1hO58AubaRJT0Gg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=McmPWhlSq6lWKHNeSOzWyidTNHMMj1MEIJ5WR5EbFdlldBAT6Qz+XQCZ8csMghcHLDqupPXGqrKPFEp6zLdZAlgtzpb/SmwOub/WZ5jyEhzfw5oAjLduEHnfURw4vi2LiCy2BTNL7AQIxXtKBCsTpi2j6nmuUBNIb0n6rolycxj4NWeuW1U1JPqFVnh1nUwWQuGwVyEK3jm7yLWOMltM+vCCFD91GCdNd1wZ9Intavtj0hpzRp2vrW9yznTpJYb1y30VCwwyNCoo+pMjHWENJiRmSJ+GbBkhjV3VFa9YKWDFfQ661c/7XXfkTvWkzMYAf9cibM820PtQGT52aRmNIg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xlco7QV7pMAHSwJ6nKlXvhaw2l1o5c1C0V82tcuoXQqqdJduZNiOtCqapSTU3zXSLjxVceq+n+7IwSSN3zEKaSIOZolj3Ufi78/lloQo4+Enia2kyzPVmVXucG65o8ojAQFpKxYybKL3lPuy5quwLl0J/q9X5Fo/xf+xb5PObjFPaAzXrcndBdfrdDMJzRyxuIhVxprNEEVp1Z6BLy7ZkMEWEDfqR910RA6lN6SSbn8LzuKvxbNcZ58U/n9ak7hJJbgHvgw5OpqP/vg1VLd2TFU1SDjriqYmNdO9+K9pD30foJdKY5N7G09qXFVNhFlLnawc75ozIX5kEjw7+Ki4UA==
  • Cc: <nd@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 06 Jun 2022 04:10:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true

In previous code, Xen was using KERN_WARNING for log message
when Xen found a node without memory. Xen will print this
warning message, and said that this may be an BIOS Bug or
mis-configured hardware. But actually, this warning is bogus,
because in an NUMA setting, nodes can only have processors,
and with 0 bytes memory. So it is unreasonable to warn about
BIOS or hardware corruption based on the detection of node
with 0 bytes memory.

So in this patch, we remove the warning messages, but just
keep an info message to info users that there is one or more
nodes with 0 bytes memory in the system.

Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v3 -> v4:
1. Remove full stop and use lower-case for node.
2. Add Rb.
v2 -> v3:
new commit.
---
 xen/arch/x86/srat.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index b145ccb847..c267d86c54 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -555,8 +555,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end)
                uint64_t size = nodes[i].end - nodes[i].start;
 
                if ( size == 0 )
-                       printk(KERN_WARNING "SRAT: Node %u has no memory. "
-                              "BIOS Bug or mis-configured hardware?\n", i);
+                       printk(KERN_INFO "SRAT: node %u has no memory\n", i);
 
                setup_node_bootmem(i, nodes[i].start, nodes[i].end);
        }
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.