[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] tools/symbols: fix memory leak in build_initial_tok_table()
- To: Yuanjun Gong <ruc_gongyuanjun@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 31 May 2022 11:03:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y+XXGINd+vyXCDIMq8ifrggk2Suqyy/MwmeDVjy+D6I=; b=JKmnCqnPkdEDdd0ZzEUtYSVaTHin6RyNmJAm9OsjMwmoEcpXwncHQbCWVYc2Xr9B4rbv9T1x76esyjihcSAYGRWrL+Y8l7dnwma2ZTEH63ifUMjh1KxPHhZYFmK4PuZ8NtgKk9KTZ8/A5Fgbe3Whk8QRthZ5oSDslQd93nis8UC31fiYInL0AFVaChlBIkRhXf1cj0hfbsF+Xe+BrHZSEP5zqvXjPv341kWZaTAPZNAvsCCJjc1l8Is7Z44VxqFCGfkEYaIJuubbBRLdDV0D31LKUt7a9fFshb5+5GA31C1NjxQSoxPM4RTVCKiMvkR2eROydRnPkn/N/GPU0/G1bA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRciIQ+M4v5+OH5K68a38/7wLHisXcXFNAZocZrgUbd8wDlmA0LLsLPz+mLeLyXO0708ZUFbMMqI4WMoubyAJ25PhR2jTv+C5EDPgw+g1OAtGDfnQFUgHI0UnGBc4IbzivExPfANS/tHLJYcIx1Y9zIVxjFzkWP9ChHUPkLK8AOk5i/9CBdEQNhS8h9eloCUrRyM7ZibG3grtd50u2V6C3HBAGSP32yj3pk8iZ9giDmelFzAPPdqemmQHXZK6v0RQxBbRHliy6JKLajfduTSuxQw1vOR/p3qmjcji7rxpKcOEHUatBY79786RlUBZxzfJmAJmZXrST7jo49d3J9DnA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 31 May 2022 09:03:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.05.2022 10:23, Yuanjun Gong wrote:
> Free the table[i].sym field of the invalid sym_entry since
> it is malloc'ed data.
It would help if you said whether this was just an observation from
e.g. static code analysis vs you actually having observed the tool
running out of memory. This is a short-lived process after all, so
"leaking" memory is not normally much of a problem.
> --- a/xen/tools/symbols.c
> +++ b/xen/tools/symbols.c
> @@ -422,6 +422,8 @@ static void build_initial_tok_table(void)
> table[pos] = table[i];
> learn_symbol(table[pos].sym, table[pos].len);
> pos++;
> + } else {
> + free(table[i].sym);
Indentation is wrong here.
Jan
|
