[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/hvm: Widen condition for is_hvm_pv_evtchn_domain() and report fix in CPUID
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 May 2022 17:14:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iIqgFGSr9cVe7EoazhtwtVTPJiaYpK3y3sv9moeCmK0=; b=cikT9eMox7XNiOK22Vg9F999ME6OKTS4kM5EqJrIsRs+VP0Enofcekpw2gBDlxoX++DGMarsJMqFP46Dej26uJwoEeKW0BkjlRj1pwfqDYxWiCeT0OQm/s2Iy1lNw6FzrT+9SklX3TnNZnYtdE9DuGSgdtMzxmDoTJR5NM1jUZZue8JHStM2/JsT2sZLhqyIMgOMo8ty1Fe83pd6N3y/v79JyxPmT8/U8Vtv26K0OSKpNQsT4mJkPgNZX0wSUrpdzlcLblOAkTg0vHLqHY9fu+90MYGNkowPTbCzaDanYM4QwA16hpLWwvi7NahsNJGGkSwbF3T1ICREpoEx9Q7Vaw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akBO7pQtHAJK23qV68IsMTB5UyktpxmJ5ieQCCnTtO+zmYAtN0hYOSM3bPyaKNJwYlxGiaJ+bpotUCnF/8peifQfIca7pv8rkWOP26z+3MxOEFLoR0AXRz/QE0WXS1rF3P9ns25Abvre9yTRvZKt+UpCKtcvo00HJL/gYeBy3NdsvqpiC3nY9CvvhzOhlo9k0o9fv8wDXJAIOWSrp1RjKfftP1sGA/p7XVYlw48WyKpmNaRUTHCT2VVlijaVBXv/mWbBeK41+gBKCm/JgutUwXZ0HzwqK34nz3J5mYxCLgVs2+/npgjmhpM+WVYQOoqhkeiD8UPwsDPZH8JrU7FQwA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 24 May 2022 15:14:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.05.2022 15:27, Jane Malalane wrote:
> --- a/xen/arch/x86/include/asm/domain.h
> +++ b/xen/arch/x86/include/asm/domain.h
> @@ -14,8 +14,14 @@
>
> #define has_32bit_shinfo(d) ((d)->arch.has_32bit_shinfo)
>
> +/*
> + * Set to true if either the global vector-type callback or per-vCPU
> + * LAPIC vectors are used. Assume all vCPUs will use
> + * HVMOP_set_evtchn_upcall_vector as long as the initial vCPU does.
> + */
> #define is_hvm_pv_evtchn_domain(d) (is_hvm_domain(d) && \
> - (d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector)
> + ((d)->arch.hvm.irq->callback_via_type == HVMIRQ_callback_vector || \
> + (d)->vcpu[0]->arch.hvm.evtchn_upcall_vector))
> #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain))
I continue to think that with the vCPU0 dependency added to
is_hvm_pv_evtchn_domain(), is_hvm_pv_evtchn_vcpu() should either
be adjusted as well (to check the correct vCPU's field) or be
deleted (and the sole caller be replaced).
Jan
|
