[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen: switch gnttab_end_foreign_access() to take a struct page pointer


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 24 May 2022 14:47:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=piYehuOsPHEH3zcOkVaVfcREcZg+X8jXeRT8GGUo2jk=; b=UQkdw0NBuNrLfsFx88NMEqrKEjIsdxTr1MipJE3PWtXIgRPY5e8isuEkhvcvyb0cnNv8M6lAa8qjpSOQ3we6eRt6PGpzhwobuwlc6C8Gbsu5Shny/AaQw8I6j8tQUAj1ESsBB7CAPa1WuJinSi43MmKmhTSvl0u+1PDrIh7m71vNAJc0q230CWKh9x1qcv91cd8RdEDaDFzYZYrZJsCjQmR5P77xQWqPYY36DO3YOG1In1E7dkfVKCGTK+qhR6Etf8lJdFlhn84u5QCTwFULho5qS+8LeOqldbYPbtK8aTXxnc40tAIoxKuTCJGgOB0jlQewwMVw7X4Cg0+ATZL/TQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JYp9DuZx+47WrOxKYbUYYXlc48Hn97mr25dKP584ke40vF0rL9SBDQ5CEfGB5k1Q476pdIkwjnyWVmMLOJvrnYNdW1BaMXcOauyu+VFyTyXkwSdFIs9kM5DRDPZDd8D30fqYqDldQvXtEnCq8I9IiQaH47Vf6cJ6oPCuR56hTLQfsNHcTDfQoZEIvQyrDdgX4g465cMs1yWco0E5EsPUr/zux42LNVBjb2cHLLcoQIrVOENs5BHO4ZJnpagq3W4jKbKb6a8TLxmLxzHug2rRogdcraqDjru7gHssLHl182pPoSYNKjqiaxpFIAKEkvqBOXX1bYBqjdsRDmcb8ija6A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Eric Van Hensbergen <ericvh@xxxxxxxxx>, Latchesar Ionkov <lucho@xxxxxxxxxx>, Dominique Martinet <asmadeus@xxxxxxxxxxxxx>, Christian Schoenebeck <linux_oss@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, v9fs-developer@xxxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 24 May 2022 12:48:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.05.2022 14:41, Juergen Gross wrote:
> Instead of a virtual kernel address use a pointer of the associated
> struct page as second parameter of gnttab_end_foreign_access().
> 
> Most users have that pointer available already and are creating the
> virtual address from it, risking problems in case the memory is
> located in highmem.
> 
> gnttab_end_foreign_access() itself won't need to get the struct page
> from the address again.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.