[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/6] xen: implement byteswap


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 23 May 2022 13:05:04 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mzIVZMyoi35U2KDDaBp06NfhSwNDMnKJNXfExSzbGXE=; b=MjdGvhZ8LrlaVddQvWTmn5zMpZCwiFd5efcc+RyqIMhPRKV9sk7sNkNyAtOUg55xSkPKTUCFbJUDCq1+v8nKcvDPkMwgcf6V74yoAHGNW9qPDzXVyfx0gJsP93xdDpysNPcCYoEXK+5X2DdXQdIPq5iR6VOqSiozP8zhYVo3a3D+St+6Zpo4yKJn1bWiCAXqP3YxleFrRuhwiFV8xP8P+rDdtmsSDovAI2tQgBceA4fti5tPU1Hrk8yVyq9qXj0vgixzmsVlEz3dO9hcSXi0tgESMIjZsd6aFwhilsSBKpwG36ILHzZwdVZCAbzsli5YmEHC/Bv8tv6E6SNoGG3B+w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gtNcHfw3xh5RcZBH0ehBCv0k5VXQXPUo/TNcR7HoFT0FsLsLeM94qJ0oDas8LvqYWcZnHg4efcUfmCXWNth692MSl5r1bxDFSNWgalYR3GbTNgbtV923CvDbtIg8q86/hY3lNo2z1uVfTjpnE1Y+jkZUsfrhGYEzTCFHf5xSOQ4Xvx7qazshIs1upjlfH+c3r0dvuDvipC9xZNRoQtsKdKEUceEUfLcG/9s25Dr9EcTOxqlGhRguTP3AAiJ5qnAuDFe3fBzBWtXUB5cpZU5/glWGcfq/rT25b3clWZp8Uq1jrPn/C4MGYorAw0mo0A4sBvdDd2wVD3zc/MTT9U1jFQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Lin Liu <lin.liu@xxxxxxxxxx>
  • Delivery-date: Mon, 23 May 2022 11:05:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.05.2022 13:00, Jan Beulich wrote:
> On 23.05.2022 12:07, Roger Pau Monné wrote:
>> Likewise the __ORDER_{BIG,LITTLE}_ENDIAN__ defines would be better
>> placed in byteswap.h itself if possible IMO, since it's not strictly
>> related to the compiler.
> 
> These need to live in per-arch headers, i.e. asm/byteorder.h.

Or rather not. __BYTE_ORDER__ looks to come from the compiler, so
#define-ing respective constants in compiler.h would seem quite
reasonable to me.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.