[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 8/8] xen/x86: use INFO level for node's without memory log message


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Wei Chen <wei.chen@xxxxxxx>
  • Date: Mon, 23 May 2022 14:25:25 +0800
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGzvy5CI0O3ZOxHFKXykWCIAbSrQeBaDVkYt3xk4464=; b=MxRw32muwCC5hE+EmCg7ucoXyUnukSHBAgCBeC+jub9xc6JGZoj6ydnWeD535Kas8cfv02ROtgJ9t4Kl5vo/rd2SC2ff+3VDqms/ah7Qc/sQkdaXzwHlMtE3qRmV9LO0rg4kmpB5lVtJBFO1Fe95amifSwAd58+tTKuNxOmrAlnCONVebrMPZFe6iQzjn3A3C8CDygzRZgiRN+4oTP1836UTwqWk/FnIuj0UQipC1MRfLoAA1lN8ob9vMTAYTWCPh0w9u5nAsUmGdHUawnJQu6mHTtiE16C2VC6yoNbhXxP+2hHP2W4cpge6J460c93XHIh4HaL2W0bo/iXSZsTtPQ==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGzvy5CI0O3ZOxHFKXykWCIAbSrQeBaDVkYt3xk4464=; b=QdvKwzQ0NKb6fXKS2hfI844uZq3LnVYD3PlXPtzFMB7owJQtsk+vQdV6mHGOOChR+rBhD7OV+1H3wGtjodZJ7ji58GJHkRiXQhcby42NybL7dtOMlnHlmQZtRnMvfkXB3L3JuP3ra4LPQY3q/UpQgpGaGG/mNeXzRJMcfqctO5PaKGwOlvKgO+Yhrv7fFkicBA+SE7S4keK0t/nCW3LhyMTt9459zSK1rRrZiGaXhelSs4yhbk3cVfEQ1ktOyAz647GyQx5C45mDqynxiN8syQHGqwW+GTrq/fwvMphBDq5zvdTV4YYPkmBpeQc6pOYMZLmi3VaKwjqe2fxgxDfBjA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KCVcJZhJUZbhnkKSMpKaO3cdh3pvmYhNpz7DFCUDQRkq0UF02uqcokFBBB/ZGRHwQu3iOeKB+1Dz4AgJJDxqhZdzT65lNQSKs8elOBRz0SXDZYBoDfETJZwFthH2Pv4lRq57+eRyHewLV1Rdc93nYpNAcL7E8jPjz7753SKt6P4wKttlyIxs65krkENwL9dyfxX9vUN3gIWauOCymZROvBdxW32pBpYe3mA5vLkjpY7PBJUGRIAiyNrb2v+5JAfGKkF6gdd4A0AgNSg023PZSwstidwUIqnQv0LYWeOAVZmVzPgxlCjD7+xovL7MU1p5QbcaMElSeyL912pPPTDD/A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYNw9B522rvIP5stLZMPI7Aswxl5/52XMGIb9s59D2LfNrlPBivZraUuhjPg4ltIYzTmn7sHkvqjMTOrl91wqay/XSNYQ9+dK7GfLK4P/Eg3RkjepdTO2z8WVmfIhzICTkKP1iqRk++GWasKebDUqwOaEpK3y6VfzT4xDaJKXKHrMKzCJ3suWyyzpODdnUbj9tURfuJRtAa7aCFGSBj6LSJ4/lAwdU8ykKTTfUJhGgKAInqRihXyvuQqafkNbsyWm4TyYVCWd6+FNCZK5XO+PUPGWoGcqLqKAm/IT2rxnacr915zJQ0TF7aM7zQgCBCpdNvBwiFMFemjytNwmDK/Ig==
  • Cc: <nd@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 23 May 2022 06:26:30 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true

In previous code, Xen was using KERN_WARNING for log message
when Xen found a node without memory. Xen will print this
warning message, and said that this may be an BIOS Bug or
mis-configured hardware. But actually, this warning is bogus,
because in an NUMA setting, nodes can only have processors,
and with 0 bytes memory. So it is unreasonable to warn about
BIOS or hardware corruption based on the detection of node
with 0 bytes memory.

So in this patch, we remove the warning messages, but just
keep an info message to info users that there is one or more
nodes with 0 bytes memory in the system.

Issue-Id: SCM-2240
Change-Id: I922a5f17e8d7e9d250a70eb3f703dabe4698027a
Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v3 -> v4:
1. Remove full stop and use lower-case for node.
2. Add Rb.
v2 -> v3:
new commit.
---
 xen/arch/x86/srat.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index a831df7648..5bd6279920 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -562,8 +562,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end)
                uint64_t size = nodes[i].end - nodes[i].start;
 
                if ( size == 0 )
-                       printk(KERN_WARNING "SRAT: Node %u has no memory. "
-                              "BIOS Bug or mis-configured hardware?\n", i);
+                       printk(KERN_INFO "SRAT: node %u has no memory\n", i);
 
                setup_node_bootmem(i, nodes[i].start, nodes[i].end);
        }
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.