[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] tools/xl: Use sparse init for dom_info, remove duplicate vars


  • To: Elliott Mitchell <ehem+xen@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 20 May 2022 14:48:00 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 20 May 2022 13:48:33 +0000
  • Ironport-data: A9a23:ZR35XK6Z6eB6cE91geIPswxRtFrHchMFZxGqfqrLsTDasY5as4F+v jcYDTqDa63cYmugfN4gbo3joRtTv5eBzdFmTFM4rCxnHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXjW1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSJZiQKGvSVgNhDCShgGnBSGI5937XIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT 5VAMGQ0PEWfC/FJEmYnFIs8w8CuvEvEYiN9gljK+JQK/WeGmWSd15CyaYGIK7RmX/59gUKwt m/AuWPjDXkyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYDUbVVa+4um0jGa7BsoZI EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUDxyKu7vON+zrHXFk8R29tTf8dk8U5EGlCO kCyoz/5OdB+mOTLFCnFr+/K8Wza1Ts9djFbO3JdJecRy5y6+dxo0EqSJjp2OPTt5uAZDw0c1 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+aTNT8D2BQwQKHhcus1rqxQFibp 2QjkMOD9u0IBpzlvHXTHb9dTeH5ua/ebme0bbtT834JrmvFxpJeVdoIvGEWyLlBb67ohgMFk GeM4FgMtfe/zVOhbLNtYpLZNijZ5fGIKDgRbdiNNoAmSsEoLGevpXgyDWbNjzGFuBV9yskXZ MbEGftA+F5HUMxP1iStfe4B3NcDn2ZmrY8lbcuglErPPHv3TCP9dIrpx3PVNbBlvP3e8VqJm zudXuPToyhivCTFSnG/2eYuwZoidxDX2bieRxRrS9O+
  • Ironport-hdrordr: A9a23:r06Dta/f4ZA9xu8ApJNuk+DaI+orL9Y04lQ7vn2YSXRuE/Bws/ re+8jztCWE7Ar5N0tNpTntAsa9qDbnhPhICOoqTNKftWvdyQiVxehZhOOIqVDd8m/Fh4xgPM 9bAtFD4bbLbWSS4/yV3DWF
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Apr 29, 2022 at 03:45:25PM -0700, Elliott Mitchell wrote:
> Rather than having shadow variables for every element of dom_info, it is
> better to properly initialize dom_info at the start.  This also removes
> the misleading memset() in the middle of main_create().
> 
> Remove the dryrun element of domain_create as that has been displaced
> by the global "dryrun_only" variable.
> 
> Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks for the clean up.

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.