[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug()
- To: Bernhard Beschow <shentey@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 19 May 2022 15:37:24 +0100
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <qemu-devel@xxxxxxxxxx>, <qemu-trivial@xxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, "open list:IDE" <qemu-block@xxxxxxxxxx>
- Delivery-date: Thu, 19 May 2022 14:37:40 +0000
- Ironport-data: A9a23:NIQFwKC8e5CfWRVW/3bkw5YqxClBgxIJ4kV8jS/XYbTApGwr1GdSn DEfXG3VMveIMWWjfNogb43n9hwF68fdytEyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Ng09Yx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhq8 sdRmL+sRj0jAbz2vuZMcAt+TiNXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8XQq+GO ptGAdZpRBSfOiwMKHosMps/oOa4nXfwUHoBtWvA8MLb5ECMlVcsgdABKuH9YN2BRcxPkgCYq 2TK8n7iBRcyMN2ZwCCCtHW2iYfnhSn8XpATEryQ7PNmgFSPgGcUDXU+UFKhqvS9zEemVd9bI UUJ/wIhqKEz8AqgSdyVdwS1pWPBtBobUNl4Feo85weQjK3O7G6xBHMCSSFpctEqtMYqAzct0 zehkt/0DCZjt5WVQHie8ayI6zW/JUA9KHQeTTUJQQsM/5/op4RbpgvCS8smDLS0kNz8HRn2x DaFqjV4gK8c5eYS2qCmuFzKnT+ojp7OSAEz+0PQRG3Nxhh5aYi5ap2A5l3S7PIGJ4GcJnGRs X5Bl8WA4eQmCZCWiDfLUOgLBKuu5fuOLHvbm1EHN4Eo6jCF63OlO4dK71lWP1x1O8wJfTvoZ k77ug5L4pJXenywYsdKj5mZUppwi/K6TJK8C66SPoEmjoVNmBGv5xt8eWOzw2/Xmnc9q4c9a LSJV5uuJCNPYUh49waeS+AY2L4t4ykxw2LPWJz2pyiaPaqiiG29EulcbgbXBgwtxObd+ViOr Y4DXyef408HONASdBU75mL6wboiCXEgTa77pMVMHgJoClo3QTpxYxM9LF5IRmCEo0i3vrqRl p1echUBoLYauZEgAVzTAk2PkJu1Af5CQYsTZETAx2qA1Xk5epqI56wCbZYxdrRP3LU9kKQkF qNZJpzeWawnptH7F9M1NMmVkWCfXE7z2VLm09SNPlDTgKKMtySWo4S5L2MDBQEFDzattNtWn lFT/lizfHb3fCw7VJy+QKv2lzuZ5CFB8MovDxqgCoQCIy3Erdk1QxEde9dqeqng3z2YnWDEv +tXaD9FzdTwT3gdqYmW2vvc9d/yewa8d2IDd1TmAX+NHXGy1gKeLUVoCY5koRi1uLvIxZif
- Ironport-hdrordr: A9a23:v08bXqwXPdbnKZsMDznDKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, May 13, 2022 at 08:09:57PM +0200, Bernhard Beschow wrote:
> This function was declared in a generic and public header, implemented
> in a device-specific source file but only used in xen_platform. Given its
> 'aux' parameter, this function is more xen-specific than piix-specific.
> Also, the hardcoded magic constants seem to be generic and related to
> PCIIDEState and IDEBus rather than piix.
>
> Therefore, move this function to xen_platform, unexport it, and drop the
> "piix3" in the function name as well.
>
> Signed-off-by: Bernhard Beschow <shentey@xxxxxxxxx>
> Reviewed-by: Paul Durrant <paul@xxxxxxx>
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
