[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/vmx: implement Notify VM Exit
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 19 May 2022 16:14:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2A1KSEKolR1dcqsQ80tDoRxBIeE5QPuyzbgsBvaRW3g=; b=QKjRdDZRzQ75kcl1kQ/3ne/1z6Z7fXMZJVyGKTcJVDlFslTrbXA/qtJq3iL6lp+Cm+VawLksrEOT5h8c1meWtQRCiuqPzi07UVR+RmWWmEQySKOKBS16BBQYEP6BftONB9Hi5Jc49PriSteK6C0s1yXzXcMEp0q7mdc5CQkGMDHL1kFdbU7fBpMsxvfNzCzbaASJxHuLrzUlR+FouvY6PWvelNe7yxBz66T7eGeXxIUKRZQ2zqYRZFZDtk53pMrWmIv9dVbUJYNpADviYRLWlEo1AsuMCWZjFw0mN+H3TamkDRLkVDUX2z8rUxE3ufzyQdMNut4ptwjUx1Cy4cOQaw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhADKJy6Y/+ofIiXNmyuxoqY7AThsTI8y/dFKhcrkUx8WYRaqSc7jnW+33SS65KRiGbQSBdPgjtPqwsPAO/ESbjsMtBZPgc13jvLUV+2UEQ3BofH4G8ArUC1MHINh5uoymMEhOVD4SdV6j95yATLrHVUTC2zaHxJhcqqQucEYvdCdN1GwWtBG5+w2uqIZETDrf+TBXI67b9eIcwImjZcKgZxdvDf6fwezFe1X+sE/xCEOA9mjgyiHHX5dkiY1/bn9Xh4AL3wgff4JX1kj5iB9N938tpqP7DvFNR/NUhnC6xv+wnXTPedHl5mAQlDxnPgHLjmDvRAYK5JUPRs2eUOow==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 19 May 2022 14:15:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.05.2022 14:44, Roger Pau Monné wrote:
> On Thu, May 19, 2022 at 08:50:55AM +0200, Jan Beulich wrote:
>> On 17.05.2022 15:21, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>>> @@ -4567,6 +4567,30 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>>> */
>>> break;
>>>
>>> + case EXIT_REASON_NOTIFY:
>>> + __vmread(EXIT_QUALIFICATION, &exit_qualification);
>>> +
>>> + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID )
>>> + {
>>> + perfc_incr(vmnotify_crash);
>>
>> Is this a useful event to count? We don't count other crash causes,
>> iirc.
>
> I thought it was helpful information from an admin PoV, but maybe I'm
> mistaken. I know we don't count other crash reasons, but that doesn't
> mean it won't be helpful to do so. Given that users have to opt-in to
> enable counters I suggest to leave the counter there.
Just to be explicit: I don't mind the counter, I merely find its addition
inconsistent with what we've got.
Jan
|
