[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Wed, 18 May 2022 10:38:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wYwl+OWIRYokE3kXxn1dDJyajJTxDekBQ4MH0IYhV/s=; b=eHc7bKQc0Lv+xxvnbFBwVnNEy/MlWOKQk7zx+6ph3ghUCByNdckxGNMFcItIgXWu5FL/qW8DQ0BuC/vgeyDG9T0VBaRNcuRGZpEt42qi83WPzOZK/Q3twfQobnbn9IXAqm2rwI4ytQ7FAouT3drlZ++IywBoMln8BoUgLWmNqgPu/u4P8v93L1ILbtTu+fKp6yR68RzX2xTnZFoPCJOYNgrXAxnDc1youtH5SKhTQHvB20fziIo4RKbBISbZtANUcM0n1nwl7Ma72NzqDSIFETUJj7LWwK4JOBNZ/NCJvCNOeGcWMFtNO2n1CaXQSoj1dNrGf48E3rKED+cBQQi6LQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KnisSz9gG+b/NlGwQXfdF+83LTa+riVbDQ7NQVWDfALFecrBBuJUCRCNOkQ+8abNFSoCFbjFAqUm1zix/7JWP1pRsHwFGPEO4xxGzqj4TrvODzwkaOyoU2NQByhuPoDZes2eqUTB1I7dg2A5r6az637ae1QAoI8tzbJXvRSVKgylorwdN43mMaZL/P9xo3JvHrIkXMzzjucXhBAnItbTmH9I+i8xx/hUd06epIcAEeYEG1GLs0DV/IEBTWzptVxEqA1iP/9EWEjENQfX3D1gy9ORVlAJFR3mjAR7MMbvDYAoM2vZP7rohopgwgdR7TJCUuLQoK4ifLpDlR1tW3AfqQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 18 May 2022 10:38:52 +0000
- Ironport-data: A9a23:Ejpw1a027UdTx6zm6vbD5aNwkn2cJEfYwER7XKvMYLTBsI5bp2YAy 2NLC2iHPvrbYWL3e90laI60pE8GupOBm9c2GVBtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMx0YDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1niqG/SzsyZ5eXgeocTTYfSHhTOoRvreqvzXiX6aR/zmXgWl61m7BLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82eBfySvbe03x9p7ixKNdTXY cdfTDNrZRDJZRBnMVYLEpMu2uyvgxETdhUH8Q/K+PBqswA/yiRN/ZKzLP3tS+a4G+BXnB2K+ WLX+nb2V0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwK8iG6JuFgbQdU4LgEhwASEy66R5hnDAGEBF2ZFcIZ/7JdwQiE23 FiUmd+vHSZorLCeVXOa8PGTsC+2Pi8Wa2QFYEfoUDc43jUqm6lr5jqnczqpOPfdYgHdcd0o/ w23kQ==
- Ironport-hdrordr: A9a23:odaeAKOHSUWvW8BcT2P155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+r5xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa33ZcjEBS5tL7tUYvJ7f2qYUh3rA37QdQCtMNDSj64IcoHK 1nC9zd/u9fdRefY2rCtmdizdSwVjBrdy32CXQqq4iQyXxbjXp5x0wXyIgWmWoB7os0T91B6/ 7fOqplmblSRosdbL57Bu0GXcyrY1a9CS7kISaXOxDqBasHM3XCp9r+56g0/vijfNgSwJ47iP 36ISdlXK4JCjfT4OG1rex2G0r2MRuAtBzWu7Fjzok8vKHgT7z2NiDGQEwykqKb0ociPvE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYZUnyc7oF7QLoj0+gbrrX4WFU9K0c9NIAgAduj4CAABjlgA==
- Thread-topic: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu()
On 18/05/2022 10:09, Jan Beulich wrote:
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> On 13.05.2022 17:39, Roger Pau Monné wrote:
>> On Wed, May 11, 2022 at 04:14:23PM +0100, Jane Malalane wrote:
>>> Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for
>>> evtchn delivery set up on a per-vCPU basis via
>>> HVMOP_set_evtchn_upcall_vector.
>>>
>>> is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up
>>> physical IRQ to event channel mappings.
>>
>> I would add something like:
>>
>> The naming of the CPUID bit is a bit generic about upcall support
>> being available. That's done so that the define name doesn't get
>> overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some
>> such.
>
> On top of this at least half a sentence wants saying on why a new
> CPUID bit is introduced in the first place. This doesn't derive in
> any way from title or description. It would be only then when it
> is additionally explained why the name was chosen like this.Indeed it is
> incomplete, thanks for pointing that out.
I could add:
"A CPUID bit is added so that guests know whether the check
in is_hvm_pv_evtchn_domain() will fail when using
HVMOP_set_evtchn_upcall_vector. This matters for guests that route
PIRQs over event channels since is_hvm_pv_evtchn_domain() is a
condition in physdev_map_pirq()."
Would this be enough clarification?
Thank you,
Jane.
|
