[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Wed, 18 May 2022 03:14:40 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0HhYL52tTZTDhLbx2gR/TD6d5xasAT8tHbEkgABTjBw=; b=GCDl5vFTUDb+qfozLbFnjStvW6imMMjBr8niNdrFlTJKvt+We1/VriDnmdf2o5N7glvmQlKIGNppwE+R3HTcTmXOp+P5BCKtmHcYVdX8MCoXYR5e8thaI4mtHvQglRpdMImkXjWBjTVB0+/OfGmHjiCta613xI68G1DTtPgABTGcNU3zBWujjmZVifrveZrVn2M6yWz+yj5zD0bY2srvjvVUy/krrvezRvW/tQmZq11QReCfEAB238SUDRWCSnyUepgCPp/WH6B8yzwEBH2D1Kdz5hgd7sab0vLY1hN4kS4py4y6kKDqMeqjPJO/xL7GQ+PkPOKEQNV4ZdKLC5vd1w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0HhYL52tTZTDhLbx2gR/TD6d5xasAT8tHbEkgABTjBw=; b=Y5jyPCkTObr/sve/TFt81ibuykeH7J7y50PbXlQ5u8RrRTawOzdOkJu0HNcF72NazZ+38O4vL2snqsaGXnr2cjdobp0l2k4JzwjBsbJDjUozD03LS49c9hMaYqQL7/7yUhGK+Hchi04MFDC0PO7vxK9izbc45ww6eZx7WX1AZ422AtNCoEBZzoAJFyQICQwZL0OpNI2K7R2pxJoFQDUSCwB9pstZr3SJFujfo45VIGuJJ+aRUpkQ/lPjmEBUnm9RHJb2kkIcYp7YnjKP3p59x0lFrCfcf4Yi9T1wG2DPzGEkBDMLOrB6sekGrHKAIKt1FC8wr8bwgZlvwvGC0kZWIg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gG1xP9Jot7bB0NesIBCHiebkYf7fOn5vD21XZzf4d0JPzjLvDKDlbhrRqjWiJT6UgEoJH+dN6OvYTiEc+pGMxkOFW4Ls05eg3FULe92iaOTSKPvGzHP1Z7LBrSGbVmhvN1YCd6vT5BrKxbuS/4wnFgCSp1KsHOkmTMm2cK4jbjnRHWS61vmfuM7zYU40MAx7DwRDwqMN1jta73IbpsrK0o6PVafFVkDuU6yPHTkUn5cHNiDs5IN8ihhtsRhEg02QTi71u/RlmUifd47SgtfVI1VdW1zyFjkv2s3nToYhsD2v6/k/aI1VOS7afNSwDkk0AT33HtZPoyWOSaIeBTW9Qw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ldeBN9w7MHV3xS4PXwD01jfnWJChXBGhfhr97wEedTa5S+pm8fBn0J+bQ8AReyU6DVc7i1AnSjbqeOllM9CZWwV76reHNjkjWJMBWn1hP8rRwOV9meL7VolCtrBHszjJrtPbQuBaF0O3QWUljkL4bW8E2X7aRn1+mRIUTrlGk2E0DH49t4cS6S7uaIOIA/xJAuZzwKAvRZihomdrUVMQav10fp9V3cxyJ0j6aoxSaesCdR3HcHVPvn0SHzWTKbynBgsFF0D3VMRJNgnJPvZfQzbfs/jX+tHpqcYqIwKmdR/KoTG/U7qPVfMXmlA16ueIZMivnvmGBKpChNZCfJDYiA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 18 May 2022 03:15:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYac1fSwyDVJqZLUSNuimuDmM9e60jOyEAgACwTiA=
- Thread-topic: [PATCH v4 2/8] xen/arm: allocate static shared memory to the default owner dom_io
Hi Jan
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, May 18, 2022 12:01 AM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>
> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Bertrand Marquis
> <Bertrand.Marquis@xxxxxxx>; Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; George Dunlap <george.dunlap@xxxxxxxxxx>;
> Wei Liu <wl@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 2/8] xen/arm: allocate static shared memory to the
> default owner dom_io
>
> On 17.05.2022 11:05, Penny Zheng wrote:
> > --- a/xen/common/domain.c
> > +++ b/xen/common/domain.c
> > @@ -780,6 +780,11 @@ void __init setup_system_domains(void)
> > * This domain owns I/O pages that are within the range of the
> > page_info
> > * array. Mappings occur at the priv of the caller.
> > * Quarantined PCI devices will be associated with this domain.
> > + *
> > + * DOMID_IO could also be used for mapping memory when no explicit
> > + * domain is specified.
> > + * For instance, DOMID_IO is the owner of memory pre-shared among
> > + * multiple domains at boot time, when no explicit owner is specified.
> > */
> > dom_io = domain_create(DOMID_IO, NULL, 0);
> > if ( IS_ERR(dom_io) )
>
> I'm sorry: The comment change is definitely better now than it was, but it is
> still written in a way requiring further knowledge to understand what it talks
> about. Without further context, "when no explicit domain is specified" only
> raises questions. I would have tried to make a suggestion, but I can't really
> figure what it is that you want to get across here.
How about I only retain the "For instance, xxx" and make it more in details.
"
DOMID_IO is also the default owner of memory pre-shared among multiple domains
at
boot time, when no explicit owner is specified with "owner" property in static
shared
memory device node. See section docs/misc/arm/device-tree/booting.txt: Static
Shared Memory
for more details.
"
>
> Jan
|
