[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list
 
- To: "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>
 
- From: Petr Mladek <pmladek@xxxxxxxx>
 
- Date: Tue, 17 May 2022 16:11:00 +0200
 
- Cc: "Luck, Tony" <tony.luck@xxxxxxxxx>, Dinh Nguyen <dinguyen@xxxxxxxxxx>,	"akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>,	"bhe@xxxxxxxxxx" <bhe@xxxxxxxxxx>,	"kexec@xxxxxxxxxxxxxxxxxxx" <kexec@xxxxxxxxxxxxxxxxxxx>,	"linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>,	"bcm-kernel-feedback-list@xxxxxxxxxxxx" <bcm-kernel-feedback-list@xxxxxxxxxxxx>,	"linuxppc-dev@xxxxxxxxxxxxxxxx" <linuxppc-dev@xxxxxxxxxxxxxxxx>,	"linux-alpha@xxxxxxxxxxxxxxx" <linux-alpha@xxxxxxxxxxxxxxx>,	"linux-edac@xxxxxxxxxxxxxxx" <linux-edac@xxxxxxxxxxxxxxx>,	"linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>,	"linux-leds@xxxxxxxxxxxxxxx" <linux-leds@xxxxxxxxxxxxxxx>,	"linux-mips@xxxxxxxxxxxxxxx" <linux-mips@xxxxxxxxxxxxxxx>,	"linux-parisc@xxxxxxxxxxxxxxx" <linux-parisc@xxxxxxxxxxxxxxx>,	"linux-pm@xxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxx>,	"linux-remoteproc@xxxxxxxxxxxxxxx" <linux-remoteproc@xxxxxxxxxxxxxxx>,	"linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>,	"linux-tegra@xxxxxxxxxxxxxxx" <linux-tegra@xxxxxxxxxxxxxxx>,	"linux-um@xxxxxxxxxxxxxxxxxxx" <linux-um@xxxxxxxxxxxxxxxxxxx>,	"linux-xtensa@xxxxxxxxxxxxxxxx" <linux-xtensa@xxxxxxxxxxxxxxxx>,	"netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>,	"openipmi-developer@xxxxxxxxxxxxxxxxxxxxx" <openipmi-developer@xxxxxxxxxxxxxxxxxxxxx>,	"rcu@xxxxxxxxxxxxxxx" <rcu@xxxxxxxxxxxxxxx>,	"sparclinux@xxxxxxxxxxxxxxx" <sparclinux@xxxxxxxxxxxxxxx>,	"xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>,	"x86@xxxxxxxxxx" <x86@xxxxxxxxxx>,	"kernel-dev@xxxxxxxxxx" <kernel-dev@xxxxxxxxxx>,	"kernel@xxxxxxxxxxxx" <kernel@xxxxxxxxxxxx>,	"halves@xxxxxxxxxxxxx" <halves@xxxxxxxxxxxxx>,	"fabiomirmar@xxxxxxxxx" <fabiomirmar@xxxxxxxxx>,	"alejandro.j.jimenez@xxxxxxxxxx" <alejandro.j.jimenez@xxxxxxxxxx>,	"andriy.shevchenko@xxxxxxxxxxxxxxx" <andriy.shevchenko@xxxxxxxxxxxxxxx>,	"arnd@xxxxxxxx" <arnd@xxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>,	"corbet@xxxxxxx" <corbet@xxxxxxx>,	"d.hatayama@xxxxxxxxxxxxxx" <d.hatayama@xxxxxxxxxxxxxx>,	"dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>,	"dyoung@xxxxxxxxxx" <dyoung@xxxxxxxxxx>,	"Tang, Feng" <feng.tang@xxxxxxxxx>,	"gregkh@xxxxxxxxxxxxxxxxxxx" <gregkh@xxxxxxxxxxxxxxxxxxx>,	"mikelley@xxxxxxxxxxxxx" <mikelley@xxxxxxxxxxxxx>,	"hidehiro.kawai.ez@xxxxxxxxxxx" <hidehiro.kawai.ez@xxxxxxxxxxx>,	"jgross@xxxxxxxx" <jgross@xxxxxxxx>,	"john.ogness@xxxxxxxxxxxxx" <john.ogness@xxxxxxxxxxxxx>,	"keescook@xxxxxxxxxxxx" <keescook@xxxxxxxxxxxx>,	"luto@xxxxxxxxxx" <luto@xxxxxxxxxx>,	"mhiramat@xxxxxxxxxx" <mhiramat@xxxxxxxxxx>,	"mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>,	"paulmck@xxxxxxxxxx" <paulmck@xxxxxxxxxx>,	"peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>,	"rostedt@xxxxxxxxxxx" <rostedt@xxxxxxxxxxx>,	"senozhatsky@xxxxxxxxxxxx" <senozhatsky@xxxxxxxxxxxx>,	"stern@xxxxxxxxxxxxxxxxxxx" <stern@xxxxxxxxxxxxxxxxxxx>,	"tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>,	"vgoyal@xxxxxxxxxx" <vgoyal@xxxxxxxxxx>,	"vkuznets@xxxxxxxxxx" <vkuznets@xxxxxxxxxx>,	"will@xxxxxxxxxx" <will@xxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>,	Alexander Gordeev <agordeev@xxxxxxxxxxxxx>,	Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>,	Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>,	Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>,	Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>,	Chris Zankel <chris@xxxxxxxxxx>,	Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>,	Corey Minyard <minyard@xxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>,	"H. Peter Anvin" <hpa@xxxxxxxxx>,	Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>,	Heiko Carstens <hca@xxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>,	Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>,	"James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>,	James Morse <james.morse@xxxxxxx>,	Johannes Berg <johannes@xxxxxxxxxxxxxxxx>,	"K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>,	Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>,	Matt Turner <mattst88@xxxxxxxxx>,	Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>,	Max Filippov <jcmvbkbc@xxxxxxxxx>,	Michael Ellerman <mpe@xxxxxxxxxxxxxx>,	Paul Mackerras <paulus@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>,	Richard Weinberger <richard@xxxxxx>,	Robert Richter <rric@xxxxxxxxxx>,	Stefano Stabellini <sstabellini@xxxxxxxxxx>,	Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>,	Sven Schnelle <svens@xxxxxxxxxxxxx>,	Vasily Gorbik <gor@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>
 
- Delivery-date: Tue, 17 May 2022 14:11:21 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On Mon 2022-05-16 13:33:51, Guilherme G. Piccoli wrote:
> On 16/05/2022 13:18, Luck, Tony wrote:
> >> [...]
> > Would it be possible to have some global "kdump is configured + enabled" 
> > flag?
> > 
> > Then notifiers could make an informed choice on whether to deep dive to
> > get all the possible details (when there is no kdump) or just skim the high
> > level stuff (to maximize chance of getting a successful kdump).
> > 
> > -Tony
> 
> Good idea Tony! What if I wire a kexec_crash_loaded() in the notifier?
I like this idea.
One small problem is that kexec_crash_loaded() has valid result
only under kexec_mutex. On the other hand, it should stay true
once loaded so that the small race window should be innocent.
> With that, are you/Petr/Dinh OK in moving it for the info list?
Sounds good to me.
Best Regards,
Petr
 
 
    
     |