[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [REGRESSION] Re: [PATCH v8 6/7] arm/dom0less: assign dom0less guests to cpupools



On 17.05.22 15:01, Andrew Cooper wrote:
On 06/05/2022 13:00, Luca Fancellu wrote:
Introduce domain-cpupool property of a xen,domain device tree node,
that specifies the cpupool device tree handle of a xen,cpupool node
that identifies a cpupool created at boot time where the guest will
be assigned on creation.

Add member to the xen_domctl_createdomain public interface so the
XEN_DOMCTL_INTERFACE_VERSION version is bumped.

Add public function to retrieve a pool id from the device tree
cpupool node.

Update documentation about the property.

Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

This has broken the Ocaml bindings, and is conceptually wrong.

The cpupool to use is a property of the vcpu, not the domain.  It isn't
legitimately part of createdomain.

What?

All vcpus of a domain are always in the same cpupool. There is no operation
"move vcpu to cpupool", but "move domain to cpupool". So your claim that
the cpupool wouldn't be a property of the domain  is IMO wrong.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.