Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure

[Julien Grall <julien@xxxxxxx>]

On 05/04/2022 22:27, Stefano Stabellini wrote:
> On Mon, 21 Feb 2022, Julien Grall wrote:
> > diff --git a/xen/arch/arm/include/asm/pmap.h b/xen/arch/arm/include/asm/pmap.h
> > new file mode 100644
> > index 000000000000..70eafe2891d7
> > --- /dev/null
> > +++ b/xen/arch/arm/include/asm/pmap.h
> > @@ -0,0 +1,33 @@
> > +#ifndef __ASM_PMAP_H__
> > +#define __ASM_PMAP_H__
> > +
> > +#include <xen/mm.h>
> > +
> > +/* XXX: Find an header to declare it */
> > +extern lpae_t xen_fixmap[XEN_PT_LPAE_ENTRIES];
> Why not fixmap.h?
I wanted to find a helper that would only get included by pmap.c and 
mm.c, this would help to prevent someone to use xen_fixmap[] directly.
Anyway, I am OK with fixmap.h and we will rely on review to catch any 
new user of xen_fixmap.
Cheers,

--
Julien Grall