Re: [PATCH 00/32] Introduce flexible array struct memcpy() helpers

[David Howells <dhowells@xxxxxxxxxx>]

Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> I'm happy to also point out that the conversions (patches 5+) are actually
> a net reduction in lines of code:
>  49 files changed, 154 insertions(+), 244 deletions(-)

That doesn't mean that it's actually code that's clearer to read.  I would say
that it's actually less clear.  In a bunch of places, you've done something
like:

-       e = kmalloc(...);
-       if (!e)
+       if (__mem_to_flex_dup(&e, ...))

The problem is that, to me at least, it looks like:

-       e = kmalloc(...);
-       if (kmalloc failed)
+       if (__mem_to_flex_dup(&e, ...) succeeded)

David