[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] ns16550: use poll mode if INTERRUPT_LINE is 0xff
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 11 May 2022 16:40:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yMXWt/M9Qsr7lS8ZgCrHGD4/arQ6gMgHS7x2uYjxOns=; b=BnVMSRT/otscfjntj0MwNB+NlfBd0UHcv4Be9XUxKFLmhEgbCzUkQgMvtJnekvDrRGNh/R7f3dQvyoDxrOPB67C/OSsPB/dgJ9k7B8ruG8K5I3qLP6uCDhyd2CnBr35nDNwjJaTGe0WiDECd0QON4fM3RAhfyNo6B3o6tzsza/Q2NyAzqN/k7tKVBgfWCOeg8GPiKyOWBqNp5BOSWSbko3AbOPJeE4Eb2hYF3LaVdtz3jEsZrtvq9SIOeQLHDZFsPhQfY70CE7wTSodXShg6jhvbi0x6rEuWgiTKse9IO7H717bq8XveNtNveMBxX5fN/+k7hKL5zBCvfHztxYJAMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZvZEYYHybrv9L5DOkUDbldgVmrRIzYGGHMkMiovz36WZke5Uic30gqg07PoaSJV5cYhU4gh3fA9k3VagCp5miyY8RAcsXOyvyatklPHFsqFq3F8TYMIz2Aam2fZiBbPB1BLYmn7b3cfZ5aPLi5/ojHrx/A/r+Y2A/f7KT8i2TpKwywK8zL+rqy9RzS0vpaFbeoLs8+NHkjvvh8tTz38X/jEz0qzPKUapxvYoGLRmWc6l+7/cub5Gb2XBp3NuA0vHCb4pQYtyOnitp2p6stYIkw3M4BwMNBIlSIwWTjRzzY/qCdLc083SD6onxhdbaQvLYcm8OLoTjjUiHrz6uqzyCQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 11 May 2022 14:40:32 +0000
- Ironport-data: A9a23:MyCFxauiM5/aGSaL18pPIn3Md+fnVGlfMUV32f8akzHdYApBsoF/q tZmKWzVOPuMYGr3KY92aY3i8xsPvZ+GzYViHFFrripgEHlB+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywobVvqYy2YLjW17U4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8TOLDtoMQDXyNyTTtbO5Z03ODfAUGg5Jn7I03uKxMAwt1IJWRvZcg037gyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4IImm5o1qiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3N9PZouzWJpOB3+LbXAufKd8K3f4ZQgVzDo nKY8Vr7CB5PYbRzzhLAqBpAnNTnmCrhXYsIGb6Q9/h0gUaSzGgeFB0XU1SgpfCzzEW5Xrp3O 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmPwKfJ5weSBkAfUyVMLtchsaceRyEu1 1KPt8PkA3poqrL9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLiJ43pgLCSJBkCqHdszHuMTT5w jTPoC1ggbwW1JYPz//ipQCBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHXlrDkldF1x28u4DQ==
- Ironport-hdrordr: A9a23:ArynpKt3NFnp3a7va5uuBaj07skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVfUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, May 11, 2022 at 02:35:05PM +0000, Andrew Cooper wrote:
> On 11/05/2022 15:15, Roger Pau Monné wrote:
> > On Wed, May 11, 2022 at 03:59:28PM +0200, Marek Marczykowski-Górecki wrote:
> >> Intel LPSS has INTERRUPT_LINE set to 0xff by default, that is declared
> >> by the PCI Local Bus Specification Revision 3.0 (from 2004) as
> >> "unknown"/"no connection". Fallback to poll mode in this case.
> >> The 0xff handling is x86-specific, the surrounding code is guarded with
> >> CONFIG_X86 anyway.
> >>
> >> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> >> ---
> >> Changes in v4:
> >> - adjust log message, change it from WARNING to INFO
> >> - re-add x86 reference in the commit message
> >> Changes in v3:
> >> - change back to checking 0xff explicitly
> >> - adjust commit message, include spec reference
> >> - change warning to match the above
> >> Changes in v2:
> >> - add log message
> >> - extend commit message
> >> - code style fix
> >> ---
> >> xen/drivers/char/ns16550.c | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
> >> index fb75cee4a13a..c0d65cff62fe 100644
> >> --- a/xen/drivers/char/ns16550.c
> >> +++ b/xen/drivers/char/ns16550.c
> >> @@ -1238,6 +1238,13 @@ pci_uart_config(struct ns16550 *uart, bool_t
> >> skip_amt, unsigned int idx)
> >> pci_conf_read8(PCI_SBDF(0, b, d, f),
> >> PCI_INTERRUPT_LINE) : 0;
> >>
> >> + if ( uart->irq == 0xff )
> >> + uart->irq = 0;
> >> + if ( !uart->irq )
> >> + printk(XENLOG_INFO
> >> + "ns16550: %pp no legacy IRQ %d, using poll
> >> mode\n",
> >> + &PCI_SBDF(0, b, d, f), uart->irq);
> > There's no point in printing ->irq as it will be 0 or else the message
> > won't be printed.
> >
> > With that fixed:
> >
> > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> TBH, can be fixed on commit, save another round of patching.
Indeed, thanks for taking care of that.
Roger.
|
