[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 9/9] xen/x86: use INFO level for node's without memory log message


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Wei Chen <wei.chen@xxxxxxx>
  • Date: Wed, 11 May 2022 09:46:39 +0800
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B7OVqHhwVjBWoKRE8rvvrSizWLkRQ9oIBYHDB2p5Tfw=; b=Xcr6ihUznxNw4Aw+EBSRCsED2Bj6f/x0IZQBsT3j4KKBecghVu8Hc+6aZWU1d2eHqqKYu4M5jYmXNydSBvBT5defpjZ6kz2BX9vobfRjwIX+M34q46zeiTmjRhu+QSXeENy9rdskhowLfBw0qblLQDA1Glrym50ApSlyK4oLc4HrZDfuB2u0QAG+pMYLWCM5h/LNQToxsFMhUNmt0eNttvGPhTO4hexMmXmqYeaZHeC9+2zJ1hL2kao6u0RPcJWGiaGa9hB2qsE+vwefe+4yTbGMTdZbXZWJ0dFLlvWOyK4xpe2TaC03okDfqsMrE8GN/hxTZj1IxFKZH3hJcaWY8w==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B7OVqHhwVjBWoKRE8rvvrSizWLkRQ9oIBYHDB2p5Tfw=; b=NFgIgtxBZsjucXbcFGT+2AZ8sdIn8s64/10GhuOPziZMa9qoZJM5hpA0bV+9KLi+PII91QORwJeAiSLhHtBS9REy7BwIsly/kNujmqgO6mN1xfI3uOYaETm9oAVgqGReSBj6yjY6Sx3GsLoX+5qCg6xtZhb+CexEJoVqD0C/ngvgR93hgun/737ZFeA83BQVx76XCmsZz4ZAbbqF1IOEF1W18ufcIoNxiE4n7MKHJp46ajCvJ4ejMp/qr8gMID6NASus9xdt58KAzBzcR6yyil03QEI6c3PJOIo0BQSugED7LBD/QGSnGETlxS3e6KMWQZdEHfzMpx9xdVKkw4llVQ==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HM2OipmOnCOjWgMMQgGYgpmgHNlejHWELKxbOPQIrqsFPytkU8/K4Aw2LWUhF619CDMYTqRBQ2kVzDoDRzPmyJ8Z1uV684MWN0RxJuvvP4tboLL7bJqttyogYhqA3jyZNPA/RrXaiF+Mm8a3FCE1uibtkk6C62n8W+TUAnskJIvLcqdUX5KQesssMNV4aD/CLAk2TDmZA3EyLS4vIKkcnThjv1Q7kIv21/CGQoHaS0R1LAG+ilgdwCjz1no7aRyh+GPR7+I5fzwvaYn6s9DLrQbgh+tPIO8J2xwdFUOixurtvKsAzzzYPrrA6MeoGLA3LkmodaTn3HCACGnj6F1ycQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ITV/SBZAa0kO5Ir92jUDuHJ29d9psI8uS/+PEHB+r3GznLByAGhc6YpOOSccxVCl7DEQXautzRyREtMWffQKal8/tkWdQsDbRjx3YTA+mEjJED3h531kL6i/xOzs1/DM90BW3BAmeDgKrSCcjq9BgMOWaJXIOlW14yjXf9/22agTOYn+8HggT80L44/r3Nh4CbIOUu5Xvd8TEi53IGHAGT0AWd5cd6J+Cz3TUH0uK4B5O9V55+dtazyfdSM736aOhufwO34xbZXrswJnnsxXWr8FTFpg15bJAerqLAj19zGMWDFmf9gyXhBmKgE3BxnNZfgIDPoZX5BBgw85xz1cYQ==
  • Cc: <nd@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 11 May 2022 01:47:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true

In previous code, Xen was using KERN_WARNING for log message
when Xen found a node without memory. Xen will print this
warning message, and said that this may be an BIOS Bug or
mis-configured hardware. But actually, this warning is bogus,
because in an NUMA setting, nodes can only have processors,
and with 0 bytes memory. So it is unreasonable to warn about
BIOS or hardware corruption based on the detection of node
with 0 bytes memory.

So in this patch, we remove the warning messages, but just
keep an info message to info users that there is one or more
nodes with 0 bytes memory in the system.

Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
---
v2 -> v3:
new commit.
---
 xen/arch/x86/srat.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
index 53835ae3eb..acaebad2a2 100644
--- a/xen/arch/x86/srat.c
+++ b/xen/arch/x86/srat.c
@@ -549,8 +549,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end)
                uint64_t size = nodes[i].end - nodes[i].start;
 
                if ( size == 0 )
-                       printk(KERN_WARNING "SRAT: Node %u has no memory. "
-                              "BIOS Bug or mis-configured hardware?\n", i);
+                       printk(KERN_INFO "SRAT: Node %u has no memory.\n", i);
 
                setup_node_bootmem(i, nodes[i].start, nodes[i].end);
        }
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.