[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] arm/its: enable LPIs before mapping the collection table
- To: Rahul Singh <Rahul.Singh@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 6 May 2022 11:28:55 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MFmDP+pUViBwraDsD59ZUeheKa7mldcdf1ksBNCJ9ZI=; b=kRhosTmdVz5ytMjpN/SHwhA7vvve6rztHWLF8KqVq4nS74hl0jXGKkmkQB8dbGmmo6szizqFim+6Ix+u9SZ5lHwARKgp8pWLJ1g7ctI565ATsFPQF9IGpLTGZv30Pu67zUKmwpuQuwA8U3s/ouC1Fmg3yg6JZgJiwLTIp7ReDzjNzLFe0A0lhIoLK4nGID44NZe9NfkON4exTQccU6XmukEnHDzuD+JQC+mDIs3bqniGTyiBImZxqhIEUnJusGQN48W9se/94OHLCCtJ/O6y5lTN5gqkkpRMCRM9u2RpZMUtzudbyHe9hnYqDOHXsvIpeRdts+XqorQvI4EvY9h2kw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MFmDP+pUViBwraDsD59ZUeheKa7mldcdf1ksBNCJ9ZI=; b=aAHdUs08tVpLbtD+y4+OyHUV1d7vsr/XVrOO5POqUlkladHIIAxA7gtIK1AJElA9qdOJg+dgGuipIW9zsCu7WdtkIc3Znh9T1iyKHF62juZVfCr84eaVNIsIDur63NYMHD8jca7t8eOz0zVr1zkewq7mlhzLCiz6ghulokdB1us7jiCZimKmdrCjTofuVAJqEbPcV2dmWxGVk1GfD5RgBmD5/TvWIjWY9X08gJ7n5Uw948CGG3hwk8Zeh4hWfCR5HDBtx0/y9Ad61T6MpmYDRb2nFggKmGGj/aKH2kda5XZmD4thBSrxeQE2UBveSWR62ZSFD++vodyW0nQzCwyqUQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Qzv6pV1iCNjVcJ4dJ/xpbCMGgodMUF2lWwEN1uPgVzNx582dBscXjDqzGs7+g6515gIL2IcNBJeU3H8CRhokbuu5X2R5ZMvsapXiNgMbPWRuIYndt4nAd5WfGXIJfUBEZJ1lguH9Hm73oaxECBjX6maX1o5ywqvBFqdvJcxRrhcccpBhYLn04NPn/nZqU6oqEV/vredocdyhnbBD/XlD8BMMdyK7vhL8Q5MRjgE0lgXh9xFfee/G8WlkWyFX8z5V1ZmQc6tUCgYWRYUJggoX33hg04AxyCePU9wsRrveZugq32x9HjUsKNZvxetBVA3iCmmVrFqDogAkye4Ao/d+0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nPVnZH8Ovk2Okdnq1y7qftBOgSiHaymX5HNF1lDqPHkAHNQxjLb6+Zj+uWJvPlLuMr8wSb+ur4fiL7q8Oj4vitHEb7ownT1D76cCkBclqIuB7PpumRgN6BtGFMVcSqIYTymT3+fErO5Pk72sMW+QjNNGVmTUV44oBmPOkYyxlFvuDUWbhmSPRlbXksa1QlWDoETcNaIIWk8Ko15/9Vye1El94YW8ObMvZJHL92rzXq3fGVJD2APyHjAhCHdbzODbZwf59qodVz/1f10RtqbrjbdOObRIBlE9gXJa3LnAgdm2thoc7lOCaKF2gReFArpPRlXbNPCdrtI606tG9fYoJw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 06 May 2022 11:29:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYX9qXT7uheGBkRkeP+IHSC5Nb6K0RuToA
- Thread-topic: [PATCH v2] arm/its: enable LPIs before mapping the collection table
Hi Rahul,
> On 4 May 2022, at 18:15, Rahul Singh <Rahul.Singh@xxxxxxx> wrote:
>
> When Xen boots on the platform that implements the GIC 600, ITS
> MAPC_LPI_OFF uncorrectable command error issue is observed.
>
> As per the GIC-600 TRM (Revision: r1p6) MAPC_LPI_OFF command error can
> be reported if the MAPC command has tried to map a collection to a core
> that does not have LPIs enabled. The definition of GICR.EnableLPIs
> also suggests enabling the LPIs before sending any ITS command that
> involves LPIs
>
> 0b0 LPI support is disabled. Any doorbell interrupt generated as a
> result of a write to a virtual LPI register must be discarded,
> and any ITS translation requests or commands involving LPIs in
> this Redistributor are ignored.
>
> 0b1 LPI support is enabled.
>
> To fix the MAPC command error issue, enable the LPIs using
> GICR_CTLR.EnableLPIs before mapping the collection table.
>
> gicv3_enable_lpis() is using writel_relaxed(), write to the GICR_CTLR
> register may not be visible before gicv3_its_setup_collection() send the
> MAPC command. Use wmb() after writel_relaxed() to make sure register
> write to enable LPIs is visible.
>
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
|
