[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] xen: add support for initializing xenstore later as HVM domain
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, jgross@xxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Thu, 5 May 2022 16:55:06 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GIQO8laz2Br665gbcj7aJdEW2CqtFMVfO3pK2txAhxE=; b=KGgWCM5ZnIJsmizEJ07Xyj2yS6MNOJ2o2Y5wCm0smq5WTOcyEv7GrCpZ0u/9hmxARnP3qtxJwAWcTCCX2UmK7CV1SlKGiAkeqp+GaAXCoK9C6VGMo+s74krHSHXNaWHkE9lQ72dJ6iZSFzYGe8Vo2HrHNXv/23U6aOOMHaP1ASAtIWZFbUP6Wwo286rR6vFIe/HQvskv7lVL+n9C1fXIjTmlb+Crpnn0dciZwJh0BI3JQeCC9505b2AhBL7bdohuhMp/EOjXs1LlnEzNWrItOj3uazsmEDviAv3MOjj976oB31KS4Xz/DgwdJCGc9Z4lsqOONzVMt5g/C+CB61CtwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RyrEqK8qm3gpCM3J6d6Ae/nwNC7JZV0jLwmoF+4qXqOUadWfZc5DEWMLCIsFvwUcm/xEM6P6MF8BpfroccaENfNDwYbmbr09qyd0gKKIzKOkWTPtVmh6xnJyQs3nb57SkKhYQK9ugzmSa7cOcdmKjwJete3653cQnPkYJW6dIUdR75PLLas/FbS7wCpoNXbz3TbAGGu658KkjbPXi96ueeoVg2ssCiz6xWVzlBGRH07zEGQmTbx+vHH75w89V7hr06X9l35P0E9ZfrEQ7Lxz7HRUucmx2i81mSsCQxtQUxDy+dYqfceyNPZIjaHZi52wsLU3kXBHVEAf4MYDrIkOZQ==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Luca Miccio <lucmiccio@xxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
- Delivery-date: Thu, 05 May 2022 20:55:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/4/22 8:23 PM, Stefano Stabellini wrote:
@@ -957,25 +989,44 @@ static int __init xenbus_init(void)
* been properly initialized. Instead of attempting to map a
* wrong guest physical address return error.
*
- * Also recognize all bits set as an invalid value.
+ * Also recognize all bits set as an invalid/uninitialized
value.
What I really meant (but not what I actually wrote I guess) was that now we are
treating -1 differently than 0 and so that comment should go ...
*/
- if (!v || !~v) {
+ if (!v) {
err = -ENOENT;
goto out_error;
}
- /* Avoid truncation on 32-bit. */
... here.
But this is ntpicking so for the series
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
+ if (v == ~0ULL) {
+ wait = true;
+ } else {
+ /* Avoid truncation on 32-bit. */
|
