[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 5 May 2022 13:13:20 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IknTPg+MA5SHn/OdlLcI4UhfMTjucHnRbWuw51/GaZE=; b=GL3Ek34g2xbuhnAeqISoqzinmdtoj71xs0D7V5UIQd0Y9Yz2lzwZ9IwyvtMqy09AfEGyCqC8gvfGEpmp2gTc3nUlYbaYplkpnjqKlgK45r9C3XCigUX5px4GwZ3RwZJc3FCGe8TatrjtjfNo0bBSb6vV6QB+YPa/IxwjWVmPpQTygbJ0FG4R4AMVLblYCkWBrqtTO+rRwokElB/zudjOZLFSJrufZYLMYi0wwX0Wp8Wlvcwy7Zw/ds1Nt3guh1BGT36DnIC7fPmMwM8lyOGDw7mGIO8qCiUwUw6PPrug+vUbWq8oIl/vphlFKiigp3p/wYzSu+7Td0M7WVXlwE0gkg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CD6gHCx1maNZt7g2nLdrvQd04jakAiV9YH2v70mSyCXsLwj2DvsgGXtzUZKdbzuNXPTaSJiiaBbbBYFThE58HTZ0QOdodS/kRsSxL7UwfTJVqyf8O2PYD//xawjMn1vi94ry0iStK+kSSVhWKv1RUfWX2bGMl1f4Xx4LnsFX59QMbHr1Nd9l+jb8UwZJ1DxZNJEBFGAi9gXkr37lCHnUN+zgGdv6r3fHyyZ8LFfvg2n0w1eAtvRx5JT5jMwP8gdgp6vGFDnZ/znr/pixqiBl75St/GhPXN2oKisWtWaDKXN/iJ2hOg8pDDFj59hTz9ofMdiKEd21NLb2QPFl6oPHYw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 05 May 2022 11:13:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05.05.2022 12:36, Michal Orzel wrote:
> --- a/xen/arch/arm/include/asm/grant_table.h
> +++ b/xen/arch/arm/include/asm/grant_table.h
> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, 
> mfn_t mfn)
>  #endif
>  }
>  
> +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain 
> *ld,
> +                                                     struct domain *rd)
> +{
> +    return false;
> +}
> +
> +static inline bool gnttab_release_host_mappings(struct domain *d)
> +{
> +    return true;
> +}

Looking at x86 I think all three instances of struct domain * want to
be const struct domain *. Then
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.