[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 5 May 2022 03:05:46 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0camEZonS80+CVpXWAhWKiF8eJGcPHgNQwdL9gW0WjA=; b=I0j03R+tV65Hwx0e19Ya9TItyB+GKaFIQLipl5krm3JOdX5GAsYAEcKK6qKUWpnX0aJExQEbz3VuH7Hf9j0CvijuhwtcxLh3AQLqdNo7gSxTaguWLrcWj5IJiTp9OEnRdc8DEXOKnEds35qrk73gdln00msA6E06vYpb96Qv2vVxKSO9FfEwGqEKTBNmA+9Ri2IQ6Z7DImjWIo/m+0AExnyfVDIxRkcY3mhq4jhTXsi52PE2G2BLyp3Tp6WFILFlRM+LXASxMmLXJ3BAASa057TlRzjWzhBU0mZQsEgaKQ/9aTokF/M4KftfSrdPaeQdupXv/PFANxe74O7DXZnjuQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0camEZonS80+CVpXWAhWKiF8eJGcPHgNQwdL9gW0WjA=; b=N9f9XISvJut/gyfeL0c9oW00vSdTJOcLrwuKUgtJ8RL+TNlcjI0oYwY/Gu5+vPZsn/Td6sj55c8JQt7GhzQwy4VFPzfxqI3Ag+xBrs27bMIuheAJqrXbmiit/OZyQNwTjY9BIa3A8RX814Tlsu3b+aF0t/4rYTRJvMygwGyZsjBYkgtVHzabAz+nZkBmhvTG3HFY0pyTZ9P1WTXdMtdnYl2CIZ3lb3gUeUlaPN82z7+AL7/3bhZfHVU004dWQqRCneRJdv5/CMGRfvJO+bP9wrum0tPRBIClby7r+elGRE8aJvEw4Eedt4b7P+7uLmRwiy//lGjJYNSybdZRWSdmdQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m2MZ48G32ypJ89kPfrkYzTha0YP5d3dbkZlumJCuhSWA85z49e42l3aTHOC95DDb32m8EkAgJxtD9aumssaClWrx1HIGsWwX2Y9Iw09PULPMHnHkkendBur9nVIm+SNyT1ymrK1KjHS6lDmChkaE8M1KWJGChWUqd0E3fzOMf0tKWwV9gGgj6TifZQDcAj5q5/IcF3NxzCSBfDmwGsiScojTqxC+PEBCGy1227Rh1qMlfJE+HXJWJS100vbNHVUDJjiHf7JUBQLQDq8u2do0w2FTPlM8lG6v1VPyLWfuhos0jbQEkwPSoV6kvaZ4I0T8vr+EUJhdIxQz8ywNpWW2Hw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KwfvWC51KH88JCmWExVWOz8polrWWg48wDeuoDIWJMlYx3Uaglb7G0ytbjotQ+DEOFvhIGvpBYC18KjMNaKYYrI8adyYkA5LEVdEWbgpCgdC7GNSOnarG9t3AvpN+/sJKtg+Ab13SIB1j+JdYQDhIPAVDpTujRV2ySczG8NNSHsH3qd12x+6CLNIppnOhNvVMN6aBlPET+L8Bld8mKLxv9U0pEDhuSz6dC8c95MRyKPbewymm/Ed4gpBLSbmae0SvMcn1DBoxMySTpdbKFbI6QTgvdF4U1EXYIExfyE6bf4wH6aXjMsz/bOoMWmwtUDMOqS4bwl2R/TA/0F1xRrT4Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Thu, 05 May 2022 03:06:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYYCt6dq3rsqHdhkOYsjKIcgbjk60PmQ0w
- Thread-topic: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after local_irq_enable
Hi,
> -----Original Message-----
> Subject: [PATCH 1/2] xen/arm: Defer request_irq on secondary CPUs after
> local_irq_enable
>
> With the enhanced ASSERT_ALLOC_CONTEXT, calling request_irq before
> local_irq_enable on secondary cores will lead to
>
> (XEN) Xen call trace:
> (XEN) [<000000000021d86c>] alloc_xenheap_pages+0x74/0x194 (PC)
> (XEN) [<000000000021d864>] alloc_xenheap_pages+0x6c/0x194 (LR)
> (XEN) [<0000000000229e90>] xmalloc_tlsf.c#xmalloc_pool_get+0x1c/0x28
> (XEN) [<000000000022a270>] xmem_pool_alloc+0x21c/0x448
> (XEN) [<000000000022a8dc>] _xmalloc+0x8c/0x290
> (XEN) [<000000000026b57c>] request_irq+0x40/0xb8
> (XEN) [<0000000000272780>] init_timer_interrupt+0x74/0xcc
> (XEN) [<000000000027212c>] start_secondary+0x1b4/0x238
> (XEN) [<0000000084000200>] 0000000084000200
> (XEN)
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 4:
> (XEN) Assertion '!in_irq() && (local_irq_is_enabled() ||
> num_online_cpus() <= 1)' failed at common/page_alloc.c:2212
> (XEN) ****************************************
>
> on systems without a big enough pool for xmalloc() to cater the
> requested size.
>
> Reported-by: Wei Chen <Wei.Chen@xxxxxxx>
> Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> Change-Id: Iebdde81f52785b0c6e037c981ff68922db016d08
Sorry about the Change-Id, forgot to remove it before sending the mail to ML,
will remove it in V2. Same for PATCH 2/2.
Kind regards,
Henry
> ---
> xen/arch/arm/smpboot.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
|
