[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/21] AMD/IOMMU: walk trees upon page fault
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 4 May 2022 17:57:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bviXjXfbxHmm9UZDT6v/R+s53wKEUsCNE2+bcKi18OQ=; b=ezOJCpJ92TNu+quIxGP2Pbe1yyGSIATJPhzUuoVBh2OCpSR0awmMyP2ffZKTTXd4FU0hinUCir8bf0L8oNxjpweY9AMvaUcKP0JtylsqYMsj7ua3lkyF2yxgmWAkN4BdHWPQRFXxhkeVHeyMdsxyL/Y6WDDG9R1SfGzPPyvoAd7iVbGh4n8Wmy5dnKVy4Yh6dAnSC2QT9tngSfdkXVSJpFcmiBdP7/3MNkpchq7hCAEyy3sNKBDlBFgvGK+1ozWUegMf36LgMKeHnjKQCRqukHDP5f4B9sE4FWn37MODnYgyY7cZ20mBmkw1bZxIKQgGYuOovF1W7n64L8IgxJ3X3A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkeQO4+Dy5RtLiXPr8TW6iFLFCuVSxJKYpAVMAQv3vrbT3dvf1egNKeh34Ua4OZ+Ni5/vf2181eVoNjThXLSDjXxEZVy7gR+3kfwn+WKA/TiBPpeYexQfl65h/aPsr3ClO8BZB0FMYq8xlhX93vxiuNKNxp+cOlvBZRpA2uHe5sGd+mLFN393dAMnVvC5ad6h1ZuOlIWJxaKZ5c93tZRX/c0M02gjGkHqWv7G/JnE9SskwFLZiXkfZcz/PQ4nf5M+Ee5tVI6NKDOUCLlQoZqwZemNo0eOZctmT7NMhpVk4cE2pfLURDQF7ddb2UKioO+T5gTMfVJe5h7F7BVxJNtkQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Wed, 04 May 2022 15:57:41 +0000
- Ironport-data: A9a23:0EJejqkxgxmHcrky9tmsdF7o5gz3J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWC2GBbqmONDP1e9AgO4/j80lSuZDRyt9rTgpk/3w0EyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EsLd9IR2NYy24DkW1/V4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYUiYMMovsluAkSAh2NA1cPfB5opHVCC3q2SCT5xWun3rE5dxLVRtzF6tIv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBg2hYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH8A/L+vdvvwA/yiQv3eC8D/z6I+ayXMMMhHTC4 UHI7WrAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQDBRtTWValrP2Rjk+lR8kZO 0ES4jApr6U56AqsVNaVdwWxvXqsrhMaHd1KHIUHBBqlz6PV50OTADgCRzsYMtg+7pZpGnoty 0ODmM7vCXp3qrqJRHmB97CS6zSvJSwSKmxEbigBJecY3+TeTEgIpkqnZr5e/GSd1LUZxRmYL +i2kRUD
- Ironport-hdrordr: A9a23:pzn0KqvtAHe4Xg3x9zqT15pD7skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Apr 25, 2022 at 10:36:42AM +0200, Jan Beulich wrote:
> This is to aid diagnosing issues and largely matches VT-d's behavior.
> Since I'm adding permissions output here as well, take the opportunity
> and also add their displaying to amd_dump_page_table_level().
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Note: "largely matches VT-d's behavior" includes the lack of any locking
> here. Adding suitable locking may not be that easy, as we'd need
> to determine which domain's mapping lock to acquire in addition to
> the necessary IOMMU lock (for the device table access), and
> whether that domain actually still exists. The latter is because
> if we really want to play safe here, imo we also need to account
> for the device table to be potentially corrupted / stale.
I think that's fine.
Thanks, Roger.
|
