[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 3 May 2022 12:21:46 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iT/bCtPMr0qhstGgPs+C59a/oEiXhzHhdk095fZmiuQ=; b=K+N06bl+h/lmlPD1jKveGArfXlImNavO5JkP31XxNH1QNGyHN4dJ9vJvGZwfgIFVKY/Qf2sndtHZMIcLycv4v8iV8x8S4cgP2SYH47qbWTjaX5GZtqQaay8LBMMpvcUnLIRJ2Q9dF7zmb45xxKQYYebBQxTrrSuuDvTZzH7M+z1yEQpASA1NfVW8g4aKVCkgTZNmAh0aSDzDq/PHTyY3hjl4p+kz/ov67no5djSFSIKAuFuaLC/vk6B3pldKbjB3aK0SeUh+shF5+6Xxg6CUTtu4+MwCc3LoRGKUjYFduDdVcGffYmZETzHMRCFYVWe25A7cJXMJ+d1whHGTqmPclQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iT/bCtPMr0qhstGgPs+C59a/oEiXhzHhdk095fZmiuQ=; b=UErwgLDWU/+8utvI10hRKQ3gjhwVHJ6uxmQJxsOqWaR/TZM3RvUtLfA5UN9DYy7FxVSWW+SWeyc5rhMYCzXNCyM7+QHyZAU6sKoeM+tFUm1i4t5WkaaUawhGmbhBwSm7l3aygR0h9zITjAjXkI2pQp2e4C3EdsoX2QgwIAVokJ8zap0iiZY2asMmSWnwrKMbHAMoRCNrL0/q31M+0j+adX7asi5CcI+mm6ZxqXuw4K5rnNYx1neI9h/ifPLMGKSmZOwSj1OJggbWgRfgCzIXcpPFxa79XM1mDLMbxSIlP/QM4XJgCp26hoDgLB6VuMwWQKSFtgnM+M6jsi5o8dvrrA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ipHnqoMr7z79jaXjJSeaQyrzVHLU2ucGIDI1pAu+H2gHJjp+azfzq/UPtNml9QiR7ZWOPjf5B0aJmpZ+WqpoM1j7oZMnlV0n+RzO5OYByFx52pW7Y4q8f8DS6FNcra0913V77jhg24xTsuZfvofzLzj24VpbTsP11V/a168beK/qVasf9vbFyK/GOsvQHkzKp7tFo9AorztJbcLAVObXoA78Mvy0tbZCnjlbXk2ZYV4ViWhrhuNhpE0ikKInXRxUoA0wSn90sRzyiYXN6UmP+1hVpUzyl6cryM5PeZSOeP8ZOyz8EXec79XTeX/uc15FHY9cOTiWuVytGFuCEYmQ/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TgHZ0cg99AHbsYXC3Autgv1Jj7Jkk7qG7XohPFva85z9Xu8u61sGlZbqzaKx4bWuNbDGEw8hiTwilCqYLWQGwxNo2G9Sk0plRHbQmjhvPbJFFTZecDdIhL3PJURtrMz8taTGT/XIPIM/2yv79EBwHIEsV3eZG5ZSxrRTlf0rHALHpGQxsrngY/pwfg9Ze9zeba4zGRUk2AITjRwODJdKkgwO0TSKILtVVAjStWHFN12PPobeyK1nhk4GFKvrXJw7TbatRR4lBrU/UsImQtslzkYOTjWTE4SosRXRUbRh+ZStDjI5ldevT8NJidBtTnBe5cgOmJaqNhjY7rCjgijNrA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Scott Davis <scott.davis@xxxxxxxxxx>, "christopher.clark@xxxxxxxxxx" <christopher.clark@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Tue, 03 May 2022 12:22:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYXijv9StER8938kifKUVqRlYIt60LmLoAgAABtwCAAAEnAIABTJWAgAAd6QCAAA5LAA==
- Thread-topic: [PATCH v5 1/2] xsm: create idle domain privileged and demote after setup
> On 3 May 2022, at 12:30, Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On 5/3/22 05:43, Luca Fancellu wrote:
>>
>>
>>> On 2 May 2022, at 14:53, Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
>>> wrote:
>>>
>>> On 5/2/22 09:49, Daniel P. Smith wrote:
>>>> On 5/2/22 09:42, Jason Andryuk wrote:
>>>>> On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith
>>>>> <dpsmith@xxxxxxxxxxxxxxxxxxxx> wrote:
>>>>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>>>>>> index d5d0792ed4..b9057222d6 100644
>>>>>> --- a/xen/arch/arm/setup.c
>>>>>> +++ b/xen/arch/arm/setup.c
>>>>>> @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long
>>>>>> boot_phys_offset,
>>>>>> /* Hide UART from DOM0 if we're using it */
>>>>>> serial_endboot();
>>>>>>
>>>>>> + if ( (rc = xsm_set_system_active()) != 0 )
>>>>>> + panic("xsm(err=%d): "
>>>>>> + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n",
>>>>>> err);
>>>>>
>>>>> You want to print rc in this message.
>>>>
>>>> Thanks, but now I want to figure out how that compile
>>>
>>> Ah, arm which I do not have a build env to do build tests.
>>
>> I’ve built this patch on arm (changing err to rc), everything looks fine, so
>> with that
>> addressed:
>>
>> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> Thank you and my apologies for not adding your review-by this morning. I
> had v6 queued to go out last night and missed this email before releasing.
>
Hi Daniel,
It’s ok I will put it again in the new serie.
Cheers,
Luca
|