[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 02/21] IOMMU: simplify unmap-on-error in iommu_map()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 3 May 2022 12:25:04 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T97w/gdwNAbA5j4mcu7BDnDUPb8/a0dHPURY2jYwcLo=; b=DOcVe0qkKNPndwP0pYFYU2w4lPLO2UVeRqHPVQzG0BIOFw6lSTbpT7ClnfWpKxNJhfUMb0QTOLxSZRPIjYanE/tCeKwPsFPlZQTDm3XMP9qMr5Yr/i48VWUXJdjcvIlblOe2FhmzRPSa5q+IHkU+ib3uimtV2WsItNd/GUW5WVoObc3hqrmuvYpTZ5m8dzzaoKUHFIlCv2l3DLjI/eQuxW6PRn+l5hlqsn7dvAox91dR5qVeXz2LMRHDzaurU1mfCBGPNVrJ/PYFfck1jSi31TP5RZvPqfhJuk1yYejtfIrkk5+f6JyNJ7M9xTLhr2yb2z7X8iZFniP6kkHM272gAw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MsWVInaWfZ7PtBBYZZvTMWRvmZxkAallbtPQz5abw6jZdzktjutMWWK7A5abk0hbngO8oUSIZGiUQGOcbVet9i0zCIs14JwkVrszV2VRLUdvcav94v6vod+ZTVZZ2BeuNEWdssZO5GjRlSpIISef5ASiZ37I9dUYKFk+lB7YvFgKr2sEOomRFd4WV7Lh0V5+73Gmcl7qYAo1XvK4Bm0eIkAWW7K1MtogOYIG2fWYunLsuzIVH6798NfIHrtxwh8Bsa1xCT5If29soycVOunjwVSJR6pdmZuMh+s+n05K7UqIEt7zCyNvFGF5Se1o1/Ht7qquxiz/LccVE5ziv5Y+hg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Tue, 03 May 2022 10:25:27 +0000
- Ironport-data: A9a23:FpixEq2oqBXnH3J4fPbD5aRwkn2cJEfYwER7XKvMYLTBsI5bp2dSm zRNDGDXOP7ZYjTzf4xzaYm+9UsGvp/Qydc1SAFlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1EU/NtTo5w7Rj2tMw2oDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1oh8G/bwQnY5b3s98xDhh4NyUnHJRZreqvzXiX6aR/zmXgWl60mbBEKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82aBfmWjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SGvLmwI9Qr9SawfykHUkwNt9+bRO4DLeOTTefdtm2OYq TeTl4j+KlRAXDCF8hKH+H+xgu7EnQvgRZkfUra/85ZCkFCVg2AeFhASfV+6uuWizF6zXcpFL E4Z8TZoqrI9nGSzR8T5dw21pjiDpBF0ZjZLO+gz6QXIwKyN5Q+cXjcAVmQZNIBgs9IqTzs30 FPPh8nuGTFkrLySTzSa66uQqjSxfyMSKAfueBM5cOfM2PG7yKlbs/4FZowL/HKd5jEtJQzN/ g==
- Ironport-hdrordr: A9a23:bHy2Sa1B5m7N1xvFn3HH/wqjBSByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQMEg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N 60Q5iApIs+MPP+UpgNdNvpYfHHfVAlEii8Rl57HzzcZdI6EkOIjaLLy5MIw8zvUKA07fIJ6e b8uRVjxCQPR34=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Apr 25, 2022 at 10:32:10AM +0200, Jan Beulich wrote:
> As of 68a8aa5d7264 ("iommu: make map and unmap take a page count,
> similar to flush") there's no need anymore to have a loop here.
>
> Suggested-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I wonder whether we should have a macro to ignore returns from
__must_check attributed functions. Ie:
#define IGNORE_RETURN(exp) while ( exp ) break;
As to avoid confusion (and having to reason) whether the usage of
while is correct. I always find it confusing to assert such loop
expressions are correct.
Thanks, Roger.
|
