Re: [PATCH 8/8] drivers/exynos4210: Remove unused-but-set variable

[Julien Grall <julien@xxxxxxx>]

Hi,

On 27/04/2022 10:49, Michal Orzel wrote:
> Function exynos4210_uart_init_preirq defines and sets a variable
> divisor but does not make use of it. Remove the definition and comment
> out the assignment as this function already has some TODOs.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> Commenting out a code is a bad practise as well as using TODOs.
I disagree, having TODOs in the code is useful to track issues that are 
not critical or necessary to update the support state.
> However the only alternative would be to get rid of divisor variable
> and TODO comments. I'm open for solutions.
I am not overly happy with commented code, but I prefer it over removing 
the TODOs comment as you wouldn't address them and the issues are not fixed.
So for this patch:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall