[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] gnttab: Remove unused-but-set variable
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 27 Apr 2022 11:59:31 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5td2FdYA/G1v27qOZaOflsBMkVwmcDVOxrFdmF7XrQg=; b=n0Eeb4JZd2gyMPzBSHC/YtOlaEBFlzkwDsgsOwkOPFwMxJjFSKObsL/nfgzX6m+1yXFcGsFcFTdaM3pN0WrXR70HO5JZpbsPzUzhhYHpqRL1NBdoM4DTgJsHNWKYCucUYwH9U1pnx1XsnVf8sCcnlNf2WBeoz2JMArzSmNAzMYRRO5nZ6ytyWsPbdyZ94fRAbiztuogMWIDdRBwlt/wBVierMGAxiYfpNRejBqZ4HKwU+t5BTtICAFBYad6/4Ink98Swu80QjCdOivgd3HNxsnzk8v9AhO192MQQfvMCyVdk/DGjxfZ/gZo8SNvYKNMX0Pjfq0LhdDZDjaHwyMKlbg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBEyMechVssUhMLieaCdDJkPRK29DDeL13vUKkuxFfojvat3do2g1+tps12Y7CQNBRBQ8oZfkDyCPR1Zqkt1MKhUUXpoxGg1sMt9QiUTVxAODyayuaDWD2JUYf/VmY3tAc9Xcg/KTDlMDerxNQVq8G9p0e5Gqje4g/XH/p7zjDlW5lvJN3YWcuvz4vOcdYMRsiL2igdTzSSxBmpmsjih7EMLImVA4fEE2ynL3tSvGZzFVIeeryO2ifuROylrnYq0giXbToDg/rkVfaxTLUkmyWVWzSd8nxKmbAmdMVbL3RudrEmW9XVzZuB92oqP6Ys2oFXvOWTaWutOFjZ73P4CWQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 27 Apr 2022 09:59:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.04.2022 11:49, Michal Orzel wrote:
> Function unmap_common_complete defines and sets a variable ld that is
> later on passed to a macro gnttab_host_mapping_get_page_type. On arm
> this macro does not make use of any arguments causing a compiler to
> warn about unused-but-set variable (when -Wunused-but-set-variable is
> enabled). Fix this by removing ld and directly passing current->domain
> to gnttab_host_mapping_get_page_type.
I think we want to retain the ld / rd notation. Therefore I think it's
rather the Arm macro which wants adjusting to not leave this argument
unused.
Jan
|
