[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/8] libxenguest: deal with log-dirty op stats overflow


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Tue, 26 Apr 2022 10:54:42 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2EXOvYM0vLVDX3/5XUuLCCDxGie+Sm6ZAc+WzdG2tIk=; b=YyKlFUGgN8xnv6SAvVC1srZg6TW31JMuv1URcmzmrj+kn4V+gjk+0m7QTYDM5s6fcqJP98uD0ROQTi2aB7oDCrEXbbUyxkfOx8tfbL29Q7ofMQWA5lb09S7GjkKscwCPCYI7AIBqPiPpTB+3w+EOltptgbHHxTyGQIoGznZBfYQB2T9E8nbF8laa4pgS1hfuP/plMQ+M60fpN1r1DLCNTDSYQXttM0HDUZkJLhMDbbLTCba8X5N7VcOCKBGRcWQNoTW8APPoeK7bHBszef0lDRF5XPPVnmcKV41jiJaJXGfGHS0dnb4Sweeupjbn5ePc+ixC+6QP5jEGVKyQfW9Ufg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b208NmdORNmvXWmtemFyZjtiXUN27g4wYDyV8izTPHOazFCNviudUodIVmHcpY8k4umwv6CfIpHIFH2+lMCclVQUYI663fBOmY8Xcj5UMGD+yCQ4wsVMFI1h+nJjDVDIi5KydyrFt4GpYyXC4MjN09TDlKaWFth0tsmYwjnGrfXwmkcBH/RJHWVA/R8IS+NXBgjPgVzp48M7duwHA5USK7AF+0F9gfhYS2nfHkXQqaYBEdrIfV3d3Hm02mbkVy2oUI+o6iZlOIFnLlM2grJ7LyUdKw8YAWplzwn/Es6MumjxTjdFA+iNI+BKWk5ILgMxT2TDy+PHWFEuaPPUkDAREQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Tue, 26 Apr 2022 10:54:55 +0000
  • Ironport-data: A9a23:4Kxp8q/duMIhpDVmSrTZDrUDgn+TJUtcMsCJ2f8bNWPcYEJGY0x3m mpNCj+GM/mPM2eje9p/aoWwp0wP6pOGzd5rS1c++Cs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw3YLnW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaGNWVYMffyLo+gUchJHHgpkfvdl+YaSdBBTseTLp6HHW13F5qw2SWsQYsgf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHP2MvIcBtNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK//FnujODl2Sd1pD2KNyPQtmEafl3l0Wb9 mbWoF75IjsFYYn3JT2ttyjEavX0tSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiGGAlg4RXZxXCeJSwAOC0K3P+C6CG3MJCDVGbbQbWNQeQDUr0 hqDmYzvDDk26LmNEyvFr/GTsC+4PjUTISkafygYQAAZ4t7l5oYukhbISdUlG6mw5jHoJQzNL /mxhHBWr90uYQQjjc1XIXivb+qQm6X0
  • Ironport-hdrordr: A9a23:P+a7/KAYJ6XGMs/lHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Vza/ppVFZql/1XwKqVKuZzIAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEniefvFmHKc7hiwlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDTa5rPw==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYWVfhm+zZwj1KrEGTWozLvDKzrK0CBWEA
  • Thread-topic: [PATCH v3 5/8] libxenguest: deal with log-dirty op stats overflow

On 26/04/2022 11:24, Jan Beulich wrote:
> In send_memory_live() the precise value the dirty_count struct field
> gets initialized to doesn't matter much

Yes it does.

And as you keep on refusing to actually fix the bugs pointed out during
review, this entire series is NACKED, seeing as you've also repeatedly
failed to address feedback from previous revisions on other patches.

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.