[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/build: Fix MAP rule when called in isolation


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 22 Apr 2022 09:04:51 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2hmD/s1ez1XCcUlh9effmB5B4jmOpv8hHy1p5xn2eW8=; b=j9EfyFQ0mY2d5gb1gN5HTo92RxW+jVLcTRw/LrIYYbgCMxipiuwbKho/70vAMdaOhkqmluIcI6V1mY79858h54avOr9S09iF/cgGpSXkZTWlw53JMlZGSmwQvd6GrDE3EebWvVtILPJAs28fxMcOjjiTjSWvK89fZbvKTZdjEpfxhfPilLP9521B2fgCCmDdKfK+4lFFRSNGo33wCbQBiwXvdQRPvtJKe3Tu4kfjFBzvZINIVytc11eJqbbQLqw8DbUwamom8jVOdupBnPT6jAP00uVmCIWPFAdS9QzX57L51OfPIsyPU0Xn+TgWW8i+89MkOQ6Lq5L0ZEbmZDzdEw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KUE3rls7LnoAAWDLC5pa/zhnUYNl8qKQcvIa9NCEj8mtKZ4h7E+g4WQ0+1uBmdbSs3PAJ7UrL94uieR/T0KvZ3MgVuvIOhGJJinebuLUV4R1wABpJPCOUORmVvUAV62cvGa2+7I+w+LEl0m2xyLMvgXszZiezDUVg48h5+zVVKaS6MGULHsqHcPFTFKOPdjxJrwNolWH4B2QEIefMU423VhgkUyx1Q/lpnFHKosoSco1OCFKA/asioyOUbw4eyByxstF1fKIwfL5oaYwjMgXbn7pFu4IonLckRx5fxDeBN73eFnct4mtcWMJO6jug+PFbeSlIchsDnVeWIIWlaQRiA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 22 Apr 2022 07:05:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21.04.2022 18:42, Andrew Cooper wrote:
> On 21/04/2022 17:09, Jan Beulich wrote:
>> On 21.04.2022 18:00, Andrew Cooper wrote:
>>> Now that `make MAP` might rebuild $(TARGET), it needs removing from
>>> no-dot-config-targets.
>> Which raises the question whether the MAP target originally was
>> meant to be used only on an already built tree, which would
>> explain the missing dependency that you added in the earlier
>> commit.
> 
> I can't comment on the previous expectation, but the fact you couldn't
> previously do `make -j4 build MAP` was simply broken.
> 
> There are also several other breakages in Xen's build system which it
> turns out is forcing all downstreams to bodge around in ways that range
> from gross to dangerous, and which need fixing for everyone's benefit. 
> (Emails will be appearing for those shortly)

Right - at least tests and cloc look to have a similar issue.

> The current debug target (just runs objdump -d) is similar to MAP,
> except I don't find it a credible target to use and was planning to
> delete it.

Well, yes. I wasn't even aware of this mis-named goal.

>>> Otherwise the build eventually fails with:
>>>
>>>     CPP     arch/x86/asm-macros.i
>>>   arch/x86/asm-macros.c:1:10: fatal error: asm/asm-defns.h: No such file or
>>>   directory
>>>       1 | #include <asm/asm-defns.h>
>>>         |          ^~~~~~~~~~~~~~~~~
>> Why would this be? asm/ isn't a symlink anymore, so should always
>> exist. I would have expected an error about .config or
>> autoconf.h not existing, ...
>>
>>> Fixes: e1e72198213b ("xen/build: Fix dependency for the MAP rule")
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> ---
>>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>>
>>> Backporting notes.  The original, e1e72198213b, wants backporting as far as 
>>> we
>>> can go.  This patch is only relevant from 6c122d3984a5e onwards, so 4.14,
>>> which is why my main developing/testing on 4.13 didn't spot it.
>> ... and the commit you reference seems to support that expectation.
> 
> I haven't spent very long investigating exactly how it breaks.  I don't
> think it's important, because the purpose of no-dot-config-targets is to
> skip large swathes of the logic.

I find it generally helpful to understand breakage when it looks odd how
exactly things break, but anyway
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.