[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] xen/scsiback: use new command result macros
- To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Wed, 20 Apr 2022 12:12:33 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iR7t+QrE0HeqxKbKGoC5cY0rBqqhBGg66dUiGeZ+tXY=; b=NL5SiBlw2G7sedeHV8cjsewEjUqYWGH1xiT8VcRzz6k6du5o5HKVsZVMJwG8q3VbUSL1TOXkBkBe6cZhUTZFIG8vjb/ZX8iN3+tg5UNH7GHQhAgDH4UtsWMrCptBJW3ub0ov0CTSDgxSUkCDJB6sigBFrkT4qj4gC49K7q7y2hqu6nmREISnqtBzCIWQkfauFjaXy+R1FumFwQ1r38WtLqMFPz9AQmPWoIcTIlUQHH4USt4iTdX2JxUGvp4VX4PfskZ80+wHzTVy2n2Ey7Wbd7UED9DGNVj4lt1EfuHIYuEL7BAtLwhRoEFVMPTqR3ZUw3gf1OyKFf3FTUchjRsdpw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/V1iIf/gYPK8TxXOnWkzrOcFR+AKsbx+neUll5y4pA8TAbspk+N9l0egW9Jc9Fe6opdLLWQF/8hwydU4SVlDzvDAAo6RAZg7nM6l00IuFZHqpLwt3sVWAFcnbHoa8yTOaljJ72YT7Jj6LACHwSPloFdTdlIFA4YnAXHfWWiIiQWXeSHzLy1Aw0aibye4xqQIDm/cxqhRFoM/B6/tXto6IzRPkWNb8ey2NibEIGrB/K6onhDXLcH8CRkqlupvsL/5lUbpWTeB52DRkZzWx0j5CnkOW11yHAEHwx0ex61gsKJeTke7spQpReROrrzpYuUhPexeBG++J2R8rpQSgRq2Q==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 16:13:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 4/20/22 5:25 AM, Juergen Gross wrote:
@@ -569,7 +645,7 @@ static void scsiback_device_action(struct vscsibk_pend
*pending_req,
wait_for_completion(&pending_req->tmr_done);
err = (se_cmd->se_tmr_req->response == TMR_FUNCTION_COMPLETE) ?
- SUCCESS : FAILED;
+ XEN_VSCSIIF_RSLT_RESET_SUCCESS : XEN_VSCSIIF_RSLT_RESET_FAILED;
scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
transport_generic_free_cmd(&pending_req->se_cmd, 0);
You also want to initialize err to XEN_VSCSIIF_RSLT_RESET_FAILED.
And also looking at invocations of scsiback_do_resp_with_sense() I think those
may need to be adjusted as well.
-boris
|
