Re: [PATCH 18/18] xen/xenbus: eliminate xenbus_grant_ring()

[Juergen Gross <jgross@xxxxxxxx>]

On 20.04.22 17:22, Andrew Cooper wrote:
> On 20/04/2022 16:09, Juergen Gross wrote:
> > diff --git a/drivers/xen/xenbus/xenbus_client.c 
> > b/drivers/xen/xenbus/xenbus_client.c
> > index 1a2e0d94ccd1..7b1f7f86b6e5 100644
> > --- a/drivers/xen/xenbus/xenbus_client.c
> > +++ b/drivers/xen/xenbus/xenbus_client.c
> > @@ -433,9 +390,24 @@ int xenbus_setup_ring(struct xenbus_device *dev, gfp_t 
> > gfp, void **vaddr,
> >                 goto err;
> >         }
> >   
> > -	ret = xenbus_grant_ring(dev, *vaddr, nr_pages, grefs);
> > -       if (ret)
> > +       ret = gnttab_alloc_grant_references(nr_pages, &gref_head);
> > +       if (ret) {
> > +               xenbus_dev_fatal(dev, ret, "granting access to ring page");
> Can we take the opportunity to unbreak this error message?  "%u ring pages".
Fine with me.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature