[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1.1 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 20 Apr 2022 14:11:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A16MhQKcqURxxiTCYMO8bhIkjnzMaBlJC3Y088Jwy3c=; b=CvHHQA8Q07gLKNWBt//t+/xActUuiaTbTjfnJ86QnHop7unaUidJprzMNNHt51QV1iUJP2sL+k1/L2pSd2wPUgenYX4Q9qMttzqRsZuZvt4Zb7RgBXeZYF2qGXlbpkDkry7vwkWpU0zLtxG1GeUCzMh6y/VI5ryA2U5FREzOKDAjkE13qDi1sO16p04azIeA5gjRk7XHydpnfzC9F75nd6G0vjA0MJJfH4NbaOM/ci8k/kp0CM8fGtpH/Jw4ytdXIQGBeIdh2NqDa/SnPyv3ts7gPwcRFiXBL+Tfv7bxnKQ+ZaXQw60ZFQaqTdPMrvmWYIQOMhm0frPLJMrjYRjmTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VnruhpWk5xsIoYcAH6YJ4eoNzGPvlrNrpBvTrxZjuknnAJ9UBNJNNyaT/NMiMrsyaW98Mm4mXZee3+GAbohPUWiqpwHRWM3sdAF9KkkJYLXmzqK28FKQxZN8CHBHRDaFT0Qs/sct2Duac3rZnPdUa1OXFKJM8igKA+XLATjNpv9rlzCpVmt0HoVWc8TBNZT0Vg2WoOgQEx4WBte8skFxd0qkyBTVxs1pcHvkIgjkBCJ8GLoWa0UP9mViPteD/4LQLkJ8jRr2ymdPuUSDYv2xGG6tQZmgEAfa+a1mouLUoqGsl9JUX44zz5aiIZO0O/bqvcuuB3F7ADpKCDoOh49tkw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 12:11:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.04.2022 18:27, Andrew Cooper wrote:
> There's no point wasting time converting binaries back to asm source. Just
> use .incbin directly. Explain in head.S what these binaries are.
Hmm, yes. Why in the world did we do this all these years?
> Also, align the blobs. While there's very little static data in the blobs,
> they should have at least 4 byte alignment. There was previously no guarantee
> that cmdline_parse_early was aligned, and there is no longer an implicit
> 4-byte alignment between cmdline_parse_early and reloc caused by the use of
> .long.
There's no alignment associated with using .long, so I think you
want to re-word this.
Jan
|
