[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] xen/iommu: cleanup iommu related domctl handling
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Apr 2022 16:41:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MmelHo0xMZYMjkYdRuVUuqugozkzocb33PhVnrTykgE=; b=F1Dir4cU+cbS/9BsS6UqefrLNrjwi7zcPu29ifIsozgLTsOTCyO76H6SK+nhAKKmWdoNhPn+xvH73/rdVvDBzljngkgjbGVEu4+6t3UfBDIUIekWwJmHY5Ae1EMwwYeGG+hNJb7YfveGDbKdlDA1yVUfoShUysuQFjJk+toAvj+h8WMydfFM/lKGCsJ8pF6FEqvxMg3ejF0YWn5l4B/9VVZyRjoglX+FyGR91gJHzmC81VN1e4aodZbgT7/qJVsgRdlW9BhOhO1UzJAu2HOTqrrdxlywHwb9cDEll+LqUsk8HM6LObqfqUHqU0Qk4PK988TXi7t40pnA3yyJyPxcPQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pp8qp4lbb6G9rXK3IhEb8CC4gNvKdEYOU+iLI/jIO0h+Rl38vR8+9zzMzGXDWMp3lBA2yK2ca5Kvu8gTfR+PRVCr1ful1MbqhKppd03CUEemWXdcH2iXWC2+TiA0+OfNhyblC2fotkhK5qBSE3wfYsA3H46IeOPAA7UZjNDJrUVZkYTdMQnb/SyrK+F0bip5wYXXrUPPd93af5PW52IBh/+vwT4Q9RnsxQjzvpO0HDie7LQtMMNomEPbnhlD1xtMfZTAI4XCSMhpFPhSpP9gZ87PFjxAfK4TlVQWFtosvXA+7d+4mzmieBqd7L3Q4Yai4BfeA9zFmCRVYYIygzY6mA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Apr 2022 14:41:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.04.2022 15:52, Juergen Gross wrote:
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -871,6 +871,13 @@ long cf_check
> do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
> copyback = 1;
> break;
>
> + case XEN_DOMCTL_assign_device:
> + case XEN_DOMCTL_test_assign_device:
> + case XEN_DOMCTL_deassign_device:
> + case XEN_DOMCTL_get_device_group:
As said in reply to Andrew, I'm not convinced having these enumerated here
is a good idea. But in any event the whole addition wants framing by
#ifdef CONFIG_HAS_PASSTHROUGH now.
For x86 I wonder whether the adjustment wouldn't allow to drop domctl.c's
including of xen/iommu.h (but perhaps it's included indirectly anyway).
Jan
> + ret = iommu_do_domctl(op, d, u_domctl);
> + break;
> +
> default:
> ret = arch_do_domctl(op, d, u_domctl);
> break;
|
