[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Julien Grall <julien.grall.oss@xxxxxxxxx>
- Date: Mon, 18 Apr 2022 23:03:52 +0000
- Cc: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jiamei Xie <Jiamei.Xie@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- Delivery-date: Mon, 18 Apr 2022 23:04:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
Sorry for the formatting issues.
> +static uint64_t virtio_mmio_base;
> +static uint32_t virtio_mmio_irq;
No need for these two variables to be global in this file, they could be
local variables in libxl__arch_domain_prepare_config.
It is more than "no need". Libxl can be used by a daemon to handle multiple domains. So we can't use static variable to keep track of local information.
Cheers,
|
