[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/11] null_blk: don't set the discard_alignment queue limit
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
- From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
- Date: Mon, 18 Apr 2022 21:22:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vHAtozakIa+rugaZJkDU64nrzSb8M+UK1EwDJHNwVhQ=; b=QLLkL5Ftm+W1VR/afboZaZBgiD6BsYT9Kl6++CYVzWq7c6FSSHLV2b1+ClMEOocv0PNLuqUCTMjj9aWB3Ftu2wBL6S6v9WmSwL2SU9kfxChyejoVXP49prZ+2s9gBs/FuB67U8e9K7ZHyZHQt0WP5OOiSUy3m4yXe6tV+Kn41irBAtqs7OnCepuZtUZKV+e5wUUMwO3nX535roLB31fUUwIEW/GXQixrZkxll6mDd5/LhRqgoZeKnG3rKAEIz7bDpD9rTq2Top909NpUIjY2pjA0nL1iNE17aHKlUb7FAhrRTYNf/qW7BOCd51WXrDCG+23xrKBmz0i7kbG41BKk1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ahltv4baQgP64rZir2XmZjBKOiurntvq0NHiJGnyOiVp/Mih+c/7k9R/sOM7dVzJLL+ydo4sCfhW9EtD6QD4AWUebh355mz/JMDv8SKWWaXEFwz/5fZkGFtVseUMjyfB66NsnYQDFMlONPuA5twN1kE1qgb7VdGAiZk928q9vEGnCuyRDda62UhJduuhL5i64q3gnwJSvLyZG3pwQRtf0yi35qmffvSH/w1aD1nU5C3nCv8bV+8zaWK2eLilrtnER5Ang6YQDtjgFiPS9TxiExtLITGIcjlrEDDV4YzeU94egJ2IG6Nj6rTaQ96pShsBrBzHOGf+5AC63Q/rad08jA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com;
- Cc: Richard Weinberger <richard@xxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Stefan Haberland <sth@xxxxxxxxxxxxx>, Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, "linux-um@xxxxxxxxxxxxxxxxxxx" <linux-um@xxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "nbd@xxxxxxxxxxxxxxxx" <nbd@xxxxxxxxxxxxxxxx>, "virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-raid@xxxxxxxxxxxxxxx" <linux-raid@xxxxxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>
- Delivery-date: Mon, 18 Apr 2022 21:22:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYUuBbOHZrkZG1wkiLxi5X413wpaz2LwoA
- Thread-topic: [PATCH 03/11] null_blk: don't set the discard_alignment queue limit
On 4/17/22 21:53, Christoph Hellwig wrote:
> The discard_alignment queue limit is named a bit misleading means the
> offset into the block device at which the discard granularity starts.
> Setting it to the discard granularity as done by null_blk is mostly
> harmless but also useless.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
-ck
|
