[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dm-devel] [PATCH 09/11] nvme: remove a spurious clear of discard_alignment
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
- From: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
- Date: Mon, 18 Apr 2022 17:02:13 +0900
- Authentication-results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com
- Cc: Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Song Liu <song@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, nbd@xxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Stefan Haberland <sth@xxxxxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 18 Apr 2022 08:02:26 +0000
- Ironport-sdr: NPz6pUrKH+IKjih5Eho4MX5TsnfwsKckpV2Oio4YneRCdHk5SNkKmAiwCmWJRgxHaXafiubSPw fWvKkvZOO6HpvHcrY/YWaX5RquicpR8u4gKy6q1b/UxZ34MkBs5OH733NOkxPTIj+2bppS9Yzl /bESb4xU/zWCqnZkE4MDapay06cfqXjSGbEIRa2oiXMRv0rfB/yR1HAZ96UtIMIwIbcI6CE2k4 2/P83vsy1BE3LGapVO1r8xoKJZnXNm8ayA+eO9IXkvHh0mjOSMp3YAk7omG/ncMaBDpJWWOl4z XUUYfWfmlCh+fAffjGgOMhOG
- Ironport-sdr: 1sk8GsPnvxngwDfq5I2X1GlngP5rHoTjXQOzOMa65Ii3FtjJvR4KGeNBfR1TFCih9IzaYzVVW0 GppzRVt0av45coByGUj3xSLrgO0TvV5O/Npw+YwuIQ+gESGb7Gqc9EKi0+tlrtRWS5Y/6E1Fw/ K8zpyI9imErcRPx+fsR7CkLEoLbXyAU3AfWsg/tgeOc0GVKKSDycQDP2w2VfjjLmdbXVfh/VvX ehu8zL8verrWCGyQgDsEpVHFSbHp1zw9CDgFZlUa1FtuSWGbQELdRZM9bcJmSubcLW2jTKY0wm 74M=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Wdcironportexception: Internal
On 4/18/22 13:53, Christoph Hellwig wrote:
> The nvme driver never sets a discard_alignment, so it also doens't need
> to clear it to zero.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> drivers/nvme/host/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b9b0fbde97c80..76a9ccd5d064a 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1628,7 +1628,6 @@ static void nvme_config_discard(struct gendisk *disk,
> struct nvme_ns *ns)
> BUILD_BUG_ON(PAGE_SIZE / sizeof(struct nvme_dsm_range) <
> NVME_DSM_MAX_RANGES);
>
> - queue->limits.discard_alignment = 0;
> queue->limits.discard_granularity = size;
>
> /* If discard is already enabled, don't reset queue limits */
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research
|
