Re: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile

[Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>]

On 4/15/22 13:52, Christoph Hellwig wrote:
> Use the bdev based helper instead of poking into the queue.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  mm/swapfile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 63c61f8b26118..4c7537162af5e 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, 
> struct inode *inode)
>                * write only restriction.  Hence zoned block devices are not
>                * suitable for swapping.  Disallow them here.
>                */
> -             if (blk_queue_is_zoned(p->bdev->bd_disk->queue))
> +             if (bdev_is_zoned(p->bdev))
>                       return -EINVAL;
>               p->flags |= SWP_BLKDEV;
>       } else if (S_ISREG(inode->i_mode)) {

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>

-- 
Damien Le Moal
Western Digital Research