[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Apr 2022 09:22:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jUYyNzsxVhsXxldtt1i9Kgkz6AJi3M9+vK2OYehpZcQ=; b=hNRIf493KU9nkLhFDVN7+Ddg8t5M2zPPfBgMlYPyxUebO/9tKL4bdMjBy8PMca64Wn7gtb2FQEVmP4HF+cXrDUHzStOWRzztXzokOgyql396u7Gdw2ejwa+tsyMOve6hEBZH9DlS9YqrcTPWTZ3bfI0kx/q+byNFtUM+t9hHDK8cGIizrSoA9iEtc6HwzAGGmE5Z9qxI4gjMyKsDMnlybnXDlka7X7kqVCb1vLFveNXzxFh9NhFLMSRz2Xm0dyoyFMPYXZMHoRfhV/kfUDKoZaOhiKselyC90vysUodVGTTSzW7Ea0XoDpKJi4vUUzRsac1uDWbXrKINfKJgtbeIKw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YSLkRzqVgY6KSY+sGjc/ZklS7Ta3RUfg5O1G1C2RNCdzEoilxB7+ocoA+hGHvHfnmfOTyJ5M0Cs/eOyDEsDMdw90JnjQfHRmhm4hLiD4Ib3MFfz0e9HTWCg5MqAFJqpTYiaaZZIYEgGJvwhLvYXcQvjcvl7oVZbG4iCmZVghvpirlph1iO65I0GoEh+pkTSRrZXexmQ43OnjHoGRq3He7fzn2ZpeZI+ip0o6Jk9l7Payuer6xwvbi3kBrXix1Qpcjla6up/9hc385z/I1qEHoO+k5hF8Uz30v7iVLWMx7cUD+2iK7OrmrebmkGbH88/0+qqgQV3Og0Eo7vBRmhyyYQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 13 Apr 2022 07:23:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.04.2022 09:15, Luca Fancellu wrote:
>
>>>
>>> No, I'm not suggesting a new menu. I was merely wondering whether the
>>> Kconfig contents wouldn't location-wise better match where the
>>> respective source file lives.
>>
>> It could be in xen/common/sched/Kconfig at the beginning of the file
>> before creating the new "Schedulers" menu, e.g.:
>>
>> diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
>> index 3d9f9214b8..f6545f4e9b 100644
>> --- a/xen/common/sched/Kconfig
>> +++ b/xen/common/sched/Kconfig
>> @@ -1,3 +1,10 @@
>> +config BOOT_TIME_CPUPOOLS
>> + bool "Create cpupools at boot time"
>> + depends on HAS_DEVICE_TREE
>> + help
>> + Creates cpupools during boot time and assigns cpus to them. Cpupools
>> + options can be specified in the device tree.
>> +
>> menu "Schedulers"
>> visible if EXPERT
>>
>>
>> I think it is fine either way, so:
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> Thank you Stefano,
>
> Jan for you is it ok at the beginning like Stefano said?
Personally I'd prefer it at the end (still outside the menu), but
really the scheduler maintainers are going to have the final say.
Jan
|
