[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/8] VT-d: refuse to use IOMMU with reserved CAP.ND value


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 12 Apr 2022 11:22:56 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j1xvT0fQk+N1z2+I1Q0QHhEkltRtiJLLoSK7wbUdhcQ=; b=nwy1qLV7BlWOdtz6MBeHeXhHwkSER3fgl3XwgfoHv4hB43a7hBXQGeuBqj4Gd8BpYvah57KWvU5+iPDdiaU+va0tRHMHCP7JX77ux3hO3F+U8Q9ee0B0RSn1fPofLH2BSvaM/7VU/7fUrzJizmf5PDGVNWV63YqNgb0ipLeG1qzzOYddk544j4gAXFZEjKxUkuRBqInHkyPWNDudMsXU32EyS/u6h6wcKhvjU9VakDEepYzB6pfMdOvxS5VmyHuZEPrmo43qqcmyMSUV++G7DEIoIfNbcJvhe2UB25RstiNk3No0sGTlPgxpYZqaOh1RPqRWLGgq+5RiZPe59LTDmQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H3Vi7gEbs7KByGdpO49C2Re+d72J+3tFIzg49SpNXO8xTx3gjCWGQO8OckTaQoOmKSN6SGF7YdNf8uin2GbD5VJQl5f5WQiLPClc+eK2sY4iLi9kaoTuYpAch5n7jzVsP2jrPIJJBpOc7OcaVisTOCAcUIZQdrqc7+06k+/DU4LXsaJMc9ewq7cFxjTq62SiNxEe0pNzMMGx/REi5NnwNMgrrktidgpc8J2Z2ZYqkMEfQxl/H53aMZz/3X6vOptb6iqMOCc2l0qJ9mFWwjWp4oseiAutj+DD3/eQnQUH84G32P0TXYK2DZAOXxeQeOaiKwchP4A2dOaRaVB9nC4ECA==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Tue, 12 Apr 2022 09:23:10 +0000
  • Ironport-data: A9a23:ABB1a66D4FRFo7wuL3kVygxRtBTHchMFZxGqfqrLsTDasY5as4F+v mYZWG+DOqnbZ2f3fY9+O4y19UNQ7ZXczNFlGlA/pHthHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YTgWVvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS+Wwl2JKPvgdgnThxKN3ojHJBcouDIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQTaiDO ppENlKDajzFb1oIJU43M6gnxuqL33b4QWx8iAua8P9fD2/7k1UqjemF3MDuUt+HW8RT2FqZr 2Tu/mLlDxVcP9uaoRKd+2+orv/Cm2X8Qo16PL+y++NugVaT7ncOExBQXly+ydGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nMEkS2Mw2 HyQo+n0AC5L6+C0dGjHqbjB+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm lhmuAB73uxO1pBTi81X6Hid21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1 UXoevRyDshTVflhdwTXGY3h+Y1FAd7fblUwZnY1QvEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R 0TYpBlc4pReVFPzM/MmPNrgW5RzkPK9fTgAahwyRoARCnSWXFXZlByCmGbKhzy9+KTSufxX1 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClY+QzF+VqWJmNvMueVNxsxoqwsBx VnkMmdww1vjn3zXbwKMb3FocrT0Wphj63k8OEQR0ZyAgRDPva7HAH8jSqYK
  • Ironport-hdrordr: A9a23:xtf53K0ai+EH6RGba6THAAqjBStyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhRQpENRGtldBm9Ce3im+yZNNW977PQCZf 6hDp0tnUveRZ1bVLXxOpFDNNKz0uHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G DZm0ihj5/T/s2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN 7Qyi1Qdfhb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBerx8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVjlx/3DE70YKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP RuNsfB//xbGGnqIEwxhlMfgOBEY05DXStvGiM5y46oOnlt7TxEJnIjtY0idixqzuN5d3FGj9 60RZiA2os+CvP+VpgNd9vpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZWXkdozvdwPpK g=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Apr 11, 2022 at 11:37:28AM +0200, Jan Beulich wrote:
> The field taking the value 7 (resulting in 18-bit DIDs when using the
> calculation in cap_ndoms(), when the DID fields are only 16 bits wide)
> is reserved. Instead of misbehaving in case we would encounter such an
> IOMMU, refuse to use it.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I would maybe prefer to get more specific error message rather than
"IOMMU: unsupported" and a dump of the iommu registers.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.