[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: make "dom0_nodes=" work with credit2
- To: Jan Beulich <JBeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Mon, 11 Apr 2022 14:33:26 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vDt+o5xfyAKPhXbyAOXsIp4kFCRyVSeCOtKAiPRC2kE=; b=Za4MbYroo0PTrm/NAvyPXmCefdaAeC55AZiH1a17WCcO4gVP7i9MTvtPjfo73U+kEOt4MQvaWrmPQmIazwz9KEasX7Ya8uDQoopR3eXdOjdbf5JwqGPb5QrkmLKmWIvjZoDJzXqtFkPkqeoj2qVsSfwZKrPKpCU5DZdjfafRT/omkM7HnZ0bvdl9OdHYym1xHJPVt93GJOcWGiiJXHWcbb12AdBZKrePEjU5ZPi2OzeBSzDFFzKtHFczHRocx87Tye1NL8JMz5TkZALotnFXIok9EhJuhXzPX48YRvg+cr3LfZQCx2e39uN/ZEj6+g1Z3tAltXeN+buzYuOQ/6sRZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQCFozCfhJV7uZS4IpRM57Co2oFToiiglg1fPW77BriZiWScLO4wUCazi086ri8YeY8LCrGgjByk25gnNUb1vqSYLsM2ubQV3uEiDMFYJN/Q5fZkNOqPxb+dvxV4OrXY4p/71l9iRNBePEE+HEWu5E1awAggyHNo3oiiy0LNYPjrGSgafNszudYEn/KV+iihtS/rEB/s2kGMN1uy1C/gKioKHnR+Ft332DQ9CP/N1vPZ3I2km+trNwLXm4cjaanhnVpxihSPEqKvd1t5P8Gjj/DN6evPiD50B24jO/2qU5OssLX2jWE2LhJkue6/wpLQyvba5P4X3T2tv36RFLOv7g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "ohering@xxxxxxx" <ohering@xxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>
- Delivery-date: Mon, 11 Apr 2022 14:33:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgATtAIA=
- Thread-topic: [PATCH] x86: make "dom0_nodes=" work with credit2
On Fri, 2022-04-08 at 11:20 +0000, Dario Faggioli wrote:
> On Thu, 2022-04-07 at 15:27 +0200, Jan Beulich wrote:
> >
> > Credit2 moving the vCPU-s off of their initially assigned ones
> > right
> > away of course renders sched_select_initial_cpu()'s use of
> > cpu_cycle()
> > pretty useless.
> >
> Mmm... you mean that Credit2 is moving the vCPUs off they're assigned
> ones _right_now_, or that it will, with this patch?
>
> If you mean the former, I'm not sure it is. In fact, when
> sched_select_initial_cpu() is called for dom0, dom0's node affinity
> is
> just all nodes, isn't it?
>
Actually, it's what results from dom0_nodes. I was forgetting that we
set d->node_affinity while parsing the parameter.
That said, I've added some logging, to better understand what is going
on, and there are some not obvious (at least, not to me) things that
are happening, and it seems that what is causing problems is the call
to sched_insert_unit(), within sched_init_vcpu().
I have to leave now, but I will report what I've found ASAP (probably
tomorrow, though).
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
|
