[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Ping: [PATCH v4 1/8] x86/boot: make "vga=current" work with graphics modes


  • To: Henry Wang <Henry.Wang@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 11 Apr 2022 11:50:34 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+goW0bkyqT+ZqMe57EdXFktRdr40TADb1pr34628B0=; b=dFKxCo44QPnEILNwzdEsfknfelyRc2fJlBw9O/b0m1/sDfP8zLNkXiw7C4t2CFgl5oxORanBBfUPRt5cK3HFvXYQ57QoX5WXBOj9VrRX5iocQ0NMwuodBfa7670aB5mXMpP2+RSRnAPOVZHIp+DsGkY4KDRdCAK2BLBCFAyc1KZaftIFfWYYKFqjK3LFTGQz1+hQXuYw1fjor87EsMF5sa0T2LQcCM6Z5QEXrGy5kf2F0IX+ROjygfVuzx0Cwi3ZA9XgcLi+lb26/Ya9URbCaTT9TwRyX3XU0bc9wLQNS2E7Gj6JqbSDx3PuCCz+Yt+/o7ZPtj/pk6+k3h6/TdUdEw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S+m/T0A20YuZn0QbnlWho/pxMZLuhf8kWa3PpXacOtzLGGWqYBL7C5Iyvuq8ShP68+LhAcbwq0pYV1Ggqa/HK61xfNMTs7QXteChdc2UA9H9eZB0EQmJcQTH+UAucZbSHz4n4zTCwUsLVrZmnwgGfQDv+Ls8qPijLzGC31HNWQeeb83fzbBEspFb9E465aKf0zrcST8FzTvkIy/Mf9pZ21dNB49Dv6tmNw87qi9T/IFncSLhK+SbhlX0ICQ8/Ch+GXRJ0PmXDRPpMcO5iMrkzd4gthWQRM0hyGWjtoJOmje5VB0pthQf7mpLAY/wkkKCzs9r9d99rVElk+7VuU0xwQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "community.manager@xxxxxxxxxxxxxx" <community.manager@xxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 11 Apr 2022 09:50:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.04.2022 16:23, Jan Beulich wrote:
> On 05.04.2022 10:45, Roger Pau Monné wrote:
>> On Thu, Mar 31, 2022 at 11:44:10AM +0200, Jan Beulich wrote:
>>> GrUB2 can be told to leave the screen in the graphics mode it has been
>>> using (or any other one), via "set gfxpayload=keep" (or suitable
>>> variants thereof). In this case we can avoid doing another mode switch
>>> ourselves. This in particular avoids possibly setting the screen to a
>>> less desirable mode: On one of my test systems the set of modes
>>> reported available by the VESA BIOS depends on whether the interposed
>>> KVM switch has that machine set as the active one. If it's not active,
>>> only modes up to 1024x768 get reported, while when active 1280x1024
>>> modes are also included. For things to always work with an explicitly
>>> specified mode (via the "vga=" option), that mode therefore needs be a
>>> 1024x768 one.
>>>
>>> For some reason this only works for me with "multiboot2" (and
>>> "module2"); "multiboot" (and "module") still forces the screen into text
>>> mode, despite my reading of the sources suggesting otherwise.
>>>
>>> For starters I'm limiting this to graphics modes; I do think this ought
>>> to also work for text modes, but
>>> - I can't tell whether GrUB2 can set any text mode other than 80x25
>>>   (I've only found plain "text" to be valid as a "gfxpayload" setting),
>>> - I'm uncertain whether supporting that is worth it, since I'm uncertain
>>>   how many people would be running their systems/screens in text mode,
>>> - I'd like to limit the amount of code added to the realmode trampoline.
>>>
>>> For starters I'm also limiting mode information retrieval to raw BIOS
>>> accesses. This will allow things to work (in principle) also with other
>>> boot environments where a graphics mode can be left in place. The
>>> downside is that this then still is dependent upon switching back to
>>> real mode, so retrieving the needed information from multiboot info is
>>> likely going to be desirable down the road.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> May I ask for an ack or otherwise for the changelog entry, please?

Ping? This is the only thing missing for me to commit the remaining
parts of this series.

Thanks, Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.