Re: [PATCH v3 06/19] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted

[Julien Grall <julien@xxxxxxx>]

Hi Stefano,

On 05/04/2022 21:49, Stefano Stabellini wrote:
> On Sat, 2 Apr 2022, Julien Grall wrote:
> > Maybe it would be clearer if I write:
> >
> >   !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN))
> It is not much a matter of clarity -- I just wanted to check with you
> the reasons for the if condition because, as you wrote, wrong tlb
> flushes can have catastrophic effects.
>
> That said, actually I prefer your second version:
>
>    !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN))
I have updated the patch to use this switch.

Cheers,

--
Julien Grall