[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD
- To: Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Sun, 10 Apr 2022 08:26:20 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, dm-devel@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Coly Li <colyli@xxxxxxx>
- Delivery-date: Sun, 10 Apr 2022 06:26:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sat, Apr 09, 2022 at 10:15:33AM +0200, Christoph Böhmwalder wrote:
> On 09.04.22 06:50, Christoph Hellwig wrote:
>> Just use a non-zero max_discard_sectors as an indicator for discard
>> support, similar to what is done for write zeroes.
>>
>> The only places where needs special attention is the RAID5 driver,
>> which must clear discard support for security reasons by default,
>> even if the default stacking rules would allow for it.
>>
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
>> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx> [btrfs]
>
> I think you may have a typo there: my ACK was for drbd, not btrfs.
Indeed, sorry.
|
